From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1F03C433F5 for ; Thu, 14 Oct 2021 06:04:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5BAF60FF2 for ; Thu, 14 Oct 2021 06:04:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229592AbhJNGGc (ORCPT ); Thu, 14 Oct 2021 02:06:32 -0400 Received: from verein.lst.de ([213.95.11.211]:48689 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbhJNGGb (ORCPT ); Thu, 14 Oct 2021 02:06:31 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id AC47068B05; Thu, 14 Oct 2021 08:04:23 +0200 (CEST) Date: Thu, 14 Oct 2021 08:04:22 +0200 From: Christoph Hellwig To: Adam Manzanares Cc: "yi.zhang@redhat.com" , "sagi@grimberg.me" , Keith Busch , Jens Axboe , Christoph Hellwig , Javier =?iso-8859-1?Q?Gonz=E1lez?= , Minwoo Im , "open list:NVM EXPRESS DRIVER" , open list Subject: Re: [PATCH] nvme: Cleanup per-namespace chardev deletion Message-ID: <20211014060422.GA24897@lst.de> References: <20211013150413.320133-1-a.manzanares@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013150413.320133-1-a.manzanares@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 13, 2021 at 03:04:19PM +0000, Adam Manzanares wrote: > Decrease reference count of chardevice during char device deletion in order to > fix a kmemleak. Add relese function for the device associated chardev and moved > ida_simple_remove into the release function. > > Fixes: 2637bae (nvme: introduce generic per-namespace chardev) > Reported-by: Yi Zhang > Suggested-by: Sagi Grimberg > Signed-off-by: Adam Manzanares This looks good, but the subject seems wrong. This isn't a cleanup but a fix. I can fix up the subject when applying it.