Re: [PATCH v10 02/11] arm64: Make perf_callchain_kernel() use arch_stack_walk()

Madhavan T. Venkataraman
2021-10-23T12:49:29Z

On 10/22/21 1:11 PM, Mark Rutland wrote:
> On Thu, Oct 14, 2021 at 09:58:38PM -0500, madvenka@linux.microsoft.com wrote:
>> From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>
>>
>> Currently, perf_callchain_kernel() in ARM64 code walks the stack using
>> start_backtrace() and walk_stackframe(). Make it use arch_stack_walk()
>> instead. This makes maintenance easier.
>>
>> Signed-off-by: Madhavan T. Venkataraman <madvenka@linux.microsoft.com>
>
> This looks good to me; bailing out when perf_callchain_store() can't
> accept any more entries absolutely makes sense.
>
> I gave this a spin with:
>
> | # perf record -g -c1 ls
> | # perf report
>
> ... and the recorded callchains look sane.
>
> Reviewed-by: Mark Rutland <mark.rutland@arm.com>
> Tested-by: Mark Rutland <mark.rutland@arm.com>
>

Thanks a lot!

> As mentioned on patch 1, I'd like to get this rebased atop Peter's
> untangling of ARCH_STACKWALK from STACKTRACE.
>

Will do.

Thanks.

Madhavan