From: Shawn Guo <shawnguo@kernel.org>
To: Alistair Francis <alistair@alistair23.me>
Cc: lee.jones@linaro.org, robh+dt@kernel.org, lgirdwood@gmail.com,
broonie@kernel.org, kernel@pengutronix.de,
s.hauer@pengutronix.de, linux-imx@nxp.com, amitk@kernel.org,
rui.zhang@intel.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alistair23@gmail.com,
linux-hwmon@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v12 10/10] ARM: dts: imx7d: remarkable2: Enable lcdif
Date: Fri, 15 Oct 2021 10:59:24 +0800 [thread overview]
Message-ID: <20211015025923.GA22881@dragon> (raw)
In-Reply-To: <20211009115732.19102-1-alistair@alistair23.me>
On Sat, Oct 09, 2021 at 09:57:32PM +1000, Alistair Francis wrote:
> Connect the dispaly on the reMarkable2.
>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
Maybe there are some patches missing. It doesn't apply to my branch.
Shawn
> ---
> arch/arm/boot/dts/imx7d-remarkable2.dts | 74 +++++++++++++++++++++++++
> 1 file changed, 74 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts
> index 1b49c26816cd..5f32c216c3fd 100644
> --- a/arch/arm/boot/dts/imx7d-remarkable2.dts
> +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts
> @@ -47,6 +47,16 @@ reg_digitizer: regulator-digitizer {
> startup-delay-us = <100000>; /* 100 ms */
> };
>
> + reg_sdoe: regulator-sdoe {
> + compatible = "regulator-fixed";
> + regulator-name = "SDOE";
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&pinctrl_sdoe_reg>;
> + pinctrl-1 = <&pinctrl_sdoe_reg>;
> + gpio = <&gpio3 27 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> wifi_pwrseq: wifi_pwrseq {
> compatible = "mmc-pwrseq-simple";
> pinctrl-names = "default";
> @@ -55,6 +65,16 @@ wifi_pwrseq: wifi_pwrseq {
> clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
> clock-names = "ext_clock";
> };
> +
> + panel {
> + compatible = "eink,vb3300-kca";
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&display_out>;
> + };
> + };
> + };
> };
>
> &clks {
> @@ -114,6 +134,20 @@ reg_epdpmic: vcom {
> };
> };
>
> +&lcdif {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_lcdif>;
> + lcd-supply = <®_epdpmic>;
> + lcd2-supply = <®_sdoe>;
> + status = "okay";
> +
> + port {
> + display_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> +};
> +
> &snvs_pwrkey {
> status = "okay";
> };
> @@ -228,6 +262,46 @@ MX7D_PAD_I2C4_SCL__I2C4_SCL 0x4000007f
> >;
> };
>
> + pinctrl_lcdif: lcdifgrp {
> + fsl,pins = <
> + MX7D_PAD_LCD_DATA00__LCD_DATA0 0x79
> + MX7D_PAD_LCD_DATA01__LCD_DATA1 0x79
> + MX7D_PAD_LCD_DATA02__LCD_DATA2 0x79
> + MX7D_PAD_LCD_DATA03__LCD_DATA3 0x79
> + MX7D_PAD_LCD_DATA04__LCD_DATA4 0x79
> + MX7D_PAD_LCD_DATA05__LCD_DATA5 0x79
> + MX7D_PAD_LCD_DATA06__LCD_DATA6 0x79
> + MX7D_PAD_LCD_DATA07__LCD_DATA7 0x79
> + MX7D_PAD_LCD_DATA08__LCD_DATA8 0x79
> + MX7D_PAD_LCD_DATA09__LCD_DATA9 0x79
> + MX7D_PAD_LCD_DATA10__LCD_DATA10 0x79
> + MX7D_PAD_LCD_DATA11__LCD_DATA11 0x79
> + MX7D_PAD_LCD_DATA12__LCD_DATA12 0x79
> + MX7D_PAD_LCD_DATA13__LCD_DATA13 0x79
> + MX7D_PAD_LCD_DATA14__LCD_DATA14 0x79
> + MX7D_PAD_LCD_DATA15__LCD_DATA15 0x79
> +
> + MX7D_PAD_LCD_DATA17__LCD_DATA17 0x79
> + MX7D_PAD_LCD_DATA18__LCD_DATA18 0x79
> + MX7D_PAD_LCD_DATA19__LCD_DATA19 0x79
> + MX7D_PAD_LCD_DATA20__LCD_DATA20 0x79
> + MX7D_PAD_LCD_DATA21__LCD_DATA21 0x79
> +
> + MX7D_PAD_LCD_DATA23__LCD_DATA23 0x79
> + MX7D_PAD_LCD_CLK__LCD_CLK 0x79
> + MX7D_PAD_LCD_ENABLE__LCD_ENABLE 0x79
> + MX7D_PAD_LCD_VSYNC__LCD_VSYNC 0x79
> + MX7D_PAD_LCD_HSYNC__LCD_HSYNC 0x79
> + MX7D_PAD_LCD_RESET__LCD_RESET 0x79
> + >;
> + };
> +
> + pinctrl_sdoe_reg: sdoereggrp {
> + fsl,pins = <
> + MX7D_PAD_LCD_DATA22__GPIO3_IO27 0x74
> + >;
> + };
> +
> pinctrl_uart1: uart1grp {
> fsl,pins = <
> MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX 0x79
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-10-15 2:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 11:57 [PATCH v12 10/10] ARM: dts: imx7d: remarkable2: Enable lcdif Alistair Francis
2021-10-15 2:59 ` Shawn Guo [this message]
2021-10-15 9:43 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015025923.GA22881@dragon \
--to=shawnguo@kernel.org \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=amitk@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox