Re: [PATCH v1] clk: samsung: update CPU clk registration

Krzysztof Kozlowski
2021-10-26T15:29:53Z

On 15/10/2021 21:05, Will McVicker wrote:
> Convert the remaining exynos clock drivers to use
> samsung_clk_register_cpu() or if possible use
> samsung_cmu_register_one(). With this we can now make
> exynos_register_cpu_clock() a static function so that future CPU clock
> registration changes will use the samsung common clock driver.
>
> The main benefit of this change is that it standardizes the CPU clock
> registration for the samsung clock drivers.
>
> Signed-off-by: Will McVicker <willmcvicker@google.com>
> ---
> drivers/clk/samsung/clk-cpu.c | 2 +-
> drivers/clk/samsung/clk-cpu.h | 7 ----
> drivers/clk/samsung/clk-exynos3250.c | 54 ++++++++++++++--------------
> drivers/clk/samsung/clk-exynos4.c | 25 +++++++------
> drivers/clk/samsung/clk-exynos5250.c | 13 +++----
> drivers/clk/samsung/clk-exynos5420.c | 27 +++++++++-----
> 6 files changed, 67 insertions(+), 61 deletions(-)
>

Looks good. Tested also on Exynos5422 board:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Best regards,
Krzysztof