From: David Lechner <david@lechnology.com>
To: linux-iio@vger.kernel.org
Cc: David Lechner <david@lechnology.com>,
William Breathitt Gray <vilhelm.gray@gmail.com>,
linux-kernel@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>
Subject: [PATCH] counter/counter-sysfs: use sysfs_emit everywhere
Date: Sun, 17 Oct 2021 14:01:06 -0500 [thread overview]
Message-ID: <20211017190106.3472645-1-david@lechnology.com> (raw)
In the counter subsystem, we are already using sysfs_emit(), but there
were a few places where we were still using sprintf() in *_show()
functions. For consistency and added protections, use sysfs_emit()
everywhere.
Suggested-by: Greg KH <gregkh@linuxfoundation.org>
Signed-off-by: David Lechner <david@lechnology.com>
---
drivers/counter/counter-sysfs.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/counter/counter-sysfs.c b/drivers/counter/counter-sysfs.c
index 7bf8882ff54d..8c2d7c29ea59 100644
--- a/drivers/counter/counter-sysfs.c
+++ b/drivers/counter/counter-sysfs.c
@@ -113,7 +113,7 @@ static ssize_t counter_comp_u8_show(struct device *dev,
/* data should already be boolean but ensure just to be safe */
data = !!data;
- return sprintf(buf, "%u\n", (unsigned int)data);
+ return sysfs_emit(buf, "%u\n", (unsigned int)data);
}
static ssize_t counter_comp_u8_store(struct device *dev,
@@ -196,7 +196,7 @@ static ssize_t counter_comp_u32_show(struct device *dev,
case COUNTER_COMP_COUNT_MODE:
return sysfs_emit(buf, "%s\n", counter_count_mode_str[data]);
default:
- return sprintf(buf, "%u\n", (unsigned int)data);
+ return sysfs_emit(buf, "%u\n", (unsigned int)data);
}
}
@@ -300,7 +300,7 @@ static ssize_t counter_comp_u64_show(struct device *dev,
if (err < 0)
return err;
- return sprintf(buf, "%llu\n", (unsigned long long)data);
+ return sysfs_emit(buf, "%llu\n", (unsigned long long)data);
}
static ssize_t counter_comp_u64_store(struct device *dev,
@@ -539,7 +539,7 @@ static ssize_t counter_comp_id_show(struct device *dev,
{
const size_t id = (size_t)to_counter_attribute(attr)->comp.priv;
- return sprintf(buf, "%zu\n", id);
+ return sysfs_emit(buf, "%zu\n", id);
}
static int counter_comp_id_attr_create(struct device *const dev,
--
2.25.1
next reply other threads:[~2021-10-17 19:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 19:01 David Lechner [this message]
2021-10-17 23:33 ` [PATCH] counter/counter-sysfs: use sysfs_emit everywhere William Breathitt Gray
2021-10-18 6:06 ` Greg KH
2021-10-18 8:19 ` William Breathitt Gray
2021-10-18 8:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211017190106.3472645-1-david@lechnology.com \
--to=david@lechnology.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox