Re: [PATCH v3 07/13] net: phy: add qca8081 get_features

Andrew Lunn
2021-10-18T21:44:18Z

On Mon, Oct 18, 2021 at 11:33:27AM +0800, Luo Jie wrote:
> Reuse the at803x phy driver get_features excepting
> adding 2500M capability.
>
> Signed-off-by: Luo Jie <luoj@codeaurora.org>
> ---
> drivers/net/phy/at803x.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index 42d3f8ccca94..0c22ef735230 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -719,6 +719,15 @@ static int at803x_get_features(struct phy_device *phydev)
> if (err)
> return err;
>
> + if (phydev->drv->phy_id == QCA8081_PHY_ID) {
> + err = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_NG_EXTABLE);
> + if (err < 0)
> + return err;
> +
> + linkmode_mod_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, phydev->supported,
> + err & MDIO_PMA_NG_EXTABLE_2_5GBT);
> + }

genphy_c45_pma_read_abilities()?

Andrew