Re: [PATCH 5.14 000/151] 5.14.14-rc1 review

Greg Kroah-Hartman
2021-10-19T09:34:54Z

On Tue, Oct 19, 2021 at 10:18:18AM +0100, Sudeep Holla wrote:
> Hi Greg,
>
> On Tue, Oct 19, 2021 at 08:13:24AM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Oct 19, 2021 at 09:08:08AM +0530, Naresh Kamboju wrote:
> > > On Mon, 18 Oct 2021 at 19:08, Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > This is the start of the stable review cycle for the 5.14.14 release.
> > > > There are 151 patches in this series, all will be posted as a response
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Wed, 20 Oct 2021 13:23:15 +0000.
> > > > Anything received after that time might be too late.
> > > >
> > > > The whole patch series can be found in one patch at:
> > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.14.14-rc1.gz
> > > > or in the git tree and branch at:
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.14.y
> > > > and the diffstat can be found below.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > > Following build errors noticed while building Linux stable rc 5.14
> > > with gcc-11 allmodconfig for arm64 architecture.
> > >
> > > - 5.14.14 gcc-11 arm64 allmodconfig FAILED
> > >
> > > > Sudeep Holla <sudeep.holla@arm.com>
> > > > firmware: arm_ffa: Add missing remove callback to ffa_bus_type
> > >
> > > drivers/firmware/arm_ffa/bus.c:96:27: error: initialization of 'int
> > > (*)(struct device *)' from incompatible pointer type 'void (*)(struct
> > > device *)' [-Werror=incompatible-pointer-types]
> > > 96 | .remove = ffa_device_remove,
> > > | ^~~~~~~~~~~~~~~~~
> > > drivers/firmware/arm_ffa/bus.c:96:27: note: (near initialization for
> > > 'ffa_bus_type.remove')
> > > cc1: some warnings being treated as errors
>
> Sorry for that.
>
> Commit fc7a6209d571 ("bus: Make remove callback return void") was merged
> in v5.15 I think.
>
> Do you need me to send the patch for v5.14 or you have already fixed it ?

I've already fixed this up, so all is good, no worries!

greg k-h