From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2942C433EF for ; Mon, 18 Oct 2021 16:18:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF9F1610C7 for ; Mon, 18 Oct 2021 16:18:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233581AbhJRQU4 (ORCPT ); Mon, 18 Oct 2021 12:20:56 -0400 Received: from elvis.franken.de ([193.175.24.41]:55145 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231768AbhJRQUx (ORCPT ); Mon, 18 Oct 2021 12:20:53 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mcVLT-0008Tz-03; Mon, 18 Oct 2021 18:18:39 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id C05E6C2616; Mon, 18 Oct 2021 18:18:00 +0200 (CEST) Date: Mon, 18 Oct 2021 18:18:00 +0200 From: Thomas Bogendoerfer To: Wan Jiabing Cc: Huacai Chen , Jiaxun Yang , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, kael_w@yeah.net Subject: Re: [PATCH] MIPS: Loongson64: Add of_node_put() before break Message-ID: <20211018161800.GD16375@alpha.franken.de> References: <20211015070122.11467-1-wanjiabing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015070122.11467-1-wanjiabing@vivo.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 15, 2021 at 03:01:22AM -0400, Wan Jiabing wrote: > Fix following coccicheck warning: > ./arch/mips/loongson64/init.c:174:1-22: WARNING: Function > for_each_node_by_name should have of_node_put() before break > > Early exits from for_each_node_by_name should decrement the > node reference counter. > > Signed-off-by: Wan Jiabing > --- > arch/mips/loongson64/init.c | 1 + > 1 file changed, 1 insertion(+) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]