From: Simon Horman <horms@kernel.org>
To: cgel.zte@gmail.com
Cc: dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Changcheng Deng <deng.changcheng@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] crash_dump: fix boolreturn.cocci warning
Date: Wed, 20 Oct 2021 12:15:31 +0200 [thread overview]
Message-ID: <20211020101531.GA22371@kernel.org> (raw)
In-Reply-To: <20211020083905.1037952-1-deng.changcheng@zte.com.cn>
On Wed, Oct 20, 2021 at 08:39:05AM +0000, cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> ./include/linux/crash_dump.h: 119: 50-51: WARNING: return of 0/1 in
> function 'is_kdump_kernel' with return type bool
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2021-10-20 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 8:39 [PATCH] crash_dump: fix boolreturn.cocci warning cgel.zte
2021-10-20 10:15 ` Simon Horman [this message]
2021-10-29 9:31 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020101531.GA22371@kernel.org \
--to=horms@kernel.org \
--cc=bhe@redhat.com \
--cc=cgel.zte@gmail.com \
--cc=deng.changcheng@zte.com.cn \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox