From: Boris Brezillon <boris.brezillon@collabora.com>
To: Sean Nyekjaer <sean@geanix.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] mtd: rawnand: nand_bbt: hide suspend/resume hooks while scanning bbt
Date: Wed, 20 Oct 2021 11:03:03 +0200 [thread overview]
Message-ID: <20211020110303.6f21c057@collabora.com> (raw)
In-Reply-To: <20211020090132.zuxojg6cnwsm4dwg@skn-laptop>
On Wed, 20 Oct 2021 11:01:32 +0200
Sean Nyekjaer <sean@geanix.com> wrote:
> On Wed, Oct 20, 2021 at 10:53:26AM +0200, Boris Brezillon wrote:
> > On Wed, 20 Oct 2021 10:45:31 +0200
> > Sean Nyekjaer <sean@geanix.com> wrote:
> >
> > > From: Boris Brezillon <boris.brezillon@collabora.com>
> > >
> > > The BBT scan logic use the MTD helpers before the MTD layer had a
> > > chance to initialize the device, and that leads to issues when
> > > accessing the uninitialized suspend lock. Let's temporarily set the
> > > suspend/resume hooks to NULL to skip the lock acquire/release step.
> > >
> > > Fixes: 013e6292aaf5 ("mtd: rawnand: Simplify the locking")
> > > Tested-by: Sean Nyekjaer <sean@geanix.com>
> >
> > It's missing our Signed-off-by tags.
> >
>
> Patch is from you ;)
> If you are okay with it, I will add your Signed-off-by tag.
You should add both (mine and yours).
next prev parent reply other threads:[~2021-10-20 9:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 8:45 [PATCH v2 0/4] mtd: core: protect access to mtd devices while in suspend Sean Nyekjaer
2021-10-20 8:45 ` [PATCH v3 1/4] mtd: rawnand: nand_bbt: hide suspend/resume hooks while scanning bbt Sean Nyekjaer
2021-10-20 8:53 ` Boris Brezillon
2021-10-20 9:01 ` Sean Nyekjaer
2021-10-20 9:03 ` Boris Brezillon [this message]
2021-10-20 9:12 ` Miquel Raynal
2021-10-20 8:45 ` [PATCH v2 2/4] mtd: core: protect access to MTD devices while in suspend Sean Nyekjaer
2021-10-20 9:13 ` Boris Brezillon
2021-10-20 8:45 ` [PATCH v2 3/4] mtd: rawnand: remove suspended check Sean Nyekjaer
2021-10-20 8:57 ` Boris Brezillon
2021-10-20 9:14 ` Sean Nyekjaer
2021-10-20 8:45 ` [PATCH v2 4/4] mtd: mtdconcat: add suspend lock handling Sean Nyekjaer
2021-10-20 8:55 ` Boris Brezillon
-- strict thread matches above, loose matches on Subject: below --
2021-10-25 9:27 [PATCH v3 0/4] mtd: core: protect access to mtd devices while in suspend Sean Nyekjaer
2021-10-25 9:27 ` [PATCH v3 1/4] mtd: rawnand: nand_bbt: hide suspend/resume hooks while scanning bbt Sean Nyekjaer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020110303.6f21c057@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=bbrezillon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=sean@geanix.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox