Re: [PATCH][net-next] netfilter: ebtables: use array_size() helper in copy_{from,to}_user()

Pablo Neira Ayuso
2021-10-21T18:16:12Z

On Thu, Oct 21, 2021 at 10:00:34AM -0700, Kees Cook wrote:
> On Tue, Sep 28, 2021 at 03:06:47PM -0500, Gustavo A. R. Silva wrote:
> > Use array_size() helper instead of the open-coded version in
> > copy_{from,to}_user(). These sorts of multiplication factors
> > need to be wrapped in array_size().
> >
> > Link: https://github.com/KSPP/linux/issues/160
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Thanks!
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> I see that this is marked "Awaiting Upstream" (for an ebtables
> maintainer ack?)
> https://patchwork.kernel.org/project/netdevbpf/patch/20210928200647.GA266402@embeddedor/

I'll route this through the netfilter tree, thanks.