Re: [PATCH v2 12/16] pinctrl: starfive: Add pinctrl driver for StarFive SoCs

Drew Fustini
2021-10-21T19:01:26Z

On Thu, Oct 21, 2021 at 07:42:19PM +0200, Emil Renner Berthing wrote:
> Add a combined pinctrl and GPIO driver for the StarFive JH7100 SoC.
>
> For each "GPIO" there are two registers for configuring the output and
> output enable signals which may come from other peripherals. Among these
> are two special signals that are constant 0 and constant 1 respectively.
> Controlling the GPIOs from software is done by choosing one of these
> signals. In other words the same registers are used for both pinmuxing
> and controlling the GPIOs, which makes it easier to combine the pinctrl
> and GPIO driver in one.
>
> I wrote the pinconf and pinmux parts, but the GPIO part of the code is
> based on the GPIO driver in the vendor tree written by Huan Feng with
> cleanups and fixes by Drew and me.
>
> Datasheet: https://github.com/starfive-tech/JH7100_Docs/blob/main/JH7100%20Data%20Sheet%20V01.01.04-EN%20(4-21-2021).pdf
> Co-developed-by: Huan Feng <huan.feng@starfivetech.com>
> Signed-off-by: Huan Feng <huan.feng@starfivetech.com>
> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
> Co-developed-by: Drew Fustini <drew@beagleboard.org>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> MAINTAINERS | 8 +
> drivers/pinctrl/Kconfig | 16 +
> drivers/pinctrl/Makefile | 1 +
> drivers/pinctrl/pinctrl-starfive.c | 1387 ++++++++++++++++++++++++++++
> 4 files changed, 1412 insertions(+)
> create mode 100644 drivers/pinctrl/pinctrl-starfive.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b3f3a29fc91f..1f122f93a5a5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17855,6 +17855,14 @@ F: Documentation/devicetree/bindings/clock/starfive,jh7100-clkgen.yaml
> F: drivers/clk/starfive/clk-starfive-jh7100.c
> F: include/dt-bindings/clock/starfive-jh7100.h
>
> +STARFIVE JH7100 PINCTRL DRIVER
> +M: Emil Renner Berthing <kernel@esmil.dk>
> +L: linux-gpio@vger.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/pinctrl/starfive,jh7100-pinctrl.yaml
> +F: drivers/pinctrl/pinctrl-starfive.c
> +F: include/dt-bindings/pinctrl/pinctrl-starfive.h
> +
> STARFIVE JH7100 RESET CONTROLLER DRIVER
> M: Emil Renner Berthing <kernel@esmil.dk>
> S: Maintained
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 31921108e456..98caa94acf9e 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -265,6 +265,22 @@ config PINCTRL_ST
> select PINCONF
> select GPIOLIB_IRQCHIP
>
> +config PINCTRL_STARFIVE
> + tristate "Pinctrl and GPIO driver for the StarFive JH7100 SoC"
> + depends on SOC_STARFIVE || COMPILE_TEST
> + default SOC_STARFIVE
> + select GENERIC_PINCTRL_GROUPS
> + select GENERIC_PINMUX_FUNCTIONS
> + select GENERIC_PINCONF
> + select GPIOLIB
> + select GPIOLIB_IRQCHIP
> + select OF_GPIO
> + help
> + Say yes here to support pin control on the StarFive JH7100 SoC.
> + This also provides an interface to the GPIO pins not used by other
> + peripherals supporting inputs, outputs, configuring pull-up/pull-down
> + and interrupts on input changes.
> +
> config PINCTRL_STMFX
> tristate "STMicroelectronics STMFX GPIO expander pinctrl driver"
> depends on I2C
> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
> index 200073bcc2c1..9c258047f11c 100644
> --- a/drivers/pinctrl/Makefile
> +++ b/drivers/pinctrl/Makefile
> @@ -38,6 +38,7 @@ obj-$(CONFIG_PINCTRL_LANTIQ) += pinctrl-lantiq.o
> obj-$(CONFIG_PINCTRL_LPC18XX) += pinctrl-lpc18xx.o
> obj-$(CONFIG_PINCTRL_TB10X) += pinctrl-tb10x.o
> obj-$(CONFIG_PINCTRL_ST) += pinctrl-st.o
> +obj-$(CONFIG_PINCTRL_STARFIVE) += pinctrl-starfive.o
> obj-$(CONFIG_PINCTRL_STMFX) += pinctrl-stmfx.o
> obj-$(CONFIG_PINCTRL_ZYNQ) += pinctrl-zynq.o
> obj-$(CONFIG_PINCTRL_ZYNQMP) += pinctrl-zynqmp.o
> diff --git a/drivers/pinctrl/pinctrl-starfive.c b/drivers/pinctrl/pinctrl-starfive.c
> new file mode 100644
> index 000000000000..ca99fad883e6
> --- /dev/null
> +++ b/drivers/pinctrl/pinctrl-starfive.c
> @@ -0,0 +1,1387 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Pinctrl / GPIO driver for StarFive JH7100 SoC
> + *
> + * Copyright (C) 2020 Shanghai StarFive Technology Co., Ltd.
> + * Copyright (C) 2021 Emil Renner Berthing <kernel@esmil.dk>
> + */
> +
> +#include <linux/bits.h>
> +#include <linux/clk.h>
> +#include <linux/gpio/driver.h>
> +#include <linux/io.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +#include <linux/reset.h>
> +#include <linux/spinlock.h>
> +
> +#include <linux/pinctrl/pinctrl.h>
> +#include <linux/pinctrl/pinmux.h>
> +
> +#include <dt-bindings/pinctrl/pinctrl-starfive.h>
> +
> +#include "core.h"
> +#include "pinctrl-utils.h"
> +#include "pinmux.h"
> +#include "pinconf.h"
> +
> +#define DRIVER_NAME "pinctrl-starfive"
> +
> +/*
> + * Refer to Section 12. GPIO Registers in the JH7100 data sheet:
> + * https://github.com/starfive-tech/JH7100_Docs
> + */
> +#define NR_GPIOS 64
> +
> +/*
> + * Global enable for GPIO interrupts. If bit 0 is set to 1 the GPIO interrupts
> + * are enabled. If set to 0 the GPIO interrupts are disabled.
> + */
> +#define GPIOEN 0x000
> +
> +/*
> + * The following 32-bit registers come in pairs, but only the offset of the
> + * first register is defined. The first controls (interrupts for) GPIO 0-31 and
> + * the second GPIO 32-63.
> + */
> +
> +/*
> + * Interrupt Type. If set to 1 the interrupt is edge-triggered. If set to 0 the
> + * interrupt is level-triggered.
> + */
> +#define GPIOIS 0x010
> +
> +/*
> + * Edge-Trigger Interrupt Type. If set to 1 the interrupt gets triggered on
> + * both positive and negative edges. If set to 0 the interrupt is triggered by a
> + * single edge.
> + */
> +#define GPIOIBE 0x018
> +
> +/*
> + * Interrupt Trigger Polarity. If set to 1 the interrupt is triggered on a
> + * rising edge (edge-triggered) or high level (level-triggered). If set to 0 the
> + * interrupt is triggered on a falling edge (edge-triggered) or low level
> + * (level-triggered).
> + */
> +#define GPIOIEV 0x020
> +
> +/*
> + * Interrupt Mask. If set to 1 the interrupt is disabled (masked). If set to 0
> + * the interrupt is enabled (unmasked).
> + */
> +#define GPIOIE 0x028

It bothered me that the datasheet used the term GPIOIE for the interrupt
mask register. I had used a more verbose #define name because I worried
someone reading GPIOIE in functions might mistake it for an interrupt
enable register. This happened to me when I was originally working with
the gpio driver.

However I suppose the best solution would have been to get the datasheet
updated as I can see how it is best to have #define names in the driver
match the datasheet.

> +
> +/*
> + * Clear Edge-Triggered Interrupts. Write a 1 to clear the edge-triggered
> + * interrupt.
> + */
> +#define GPIOIC 0x030
> +
> +/*
> + * Edge-Triggered Interrupt Status. A 1 means the configured edge was detected.
> + */
> +#define GPIORIS 0x038
> +
> +/*
> + * Interrupt Status after Masking. A 1 means the configured edge or level was
> + * detected and not masked.
> + */
> +#define GPIOMIS 0x040
> +
> +/*
> + * Data Value. Dynamically reflects the value of the GPIO pin. If 1 the pin is
> + * a digital 1 and if 0 the pin is a digital 0.
> + */
> +#define GPIODIN 0x048
> +
> +/*
> + * From the data sheet section 12.2, there are 64 32-bit output data registers
> + * and 64 output enable registers. Output data and output enable registers for
> + * a given GPIO are contiguous. Eg. GPO0_DOUT_CFG is 0x50 and GPO0_DOEN_CFG is
> + * 0x54 while GPO1_DOUT_CFG is 0x58 and GPO1_DOEN_CFG is 0x5c. The stride
> + * between GPIO registers is effectively 8, thus: GPOn_DOUT_CFG is 0x50 + 8n
> + * and GPOn_DOEN_CFG is 0x54 + 8n.
> + */
> +#define GPON_DOUT_CFG 0x050
> +#define GPON_DOEN_CFG 0x054
> +
> +/*
> + * From Section 12.3, there are 75 input signal configuration registers which
> + * are 4 bytes wide starting with GPI_CPU_JTAG_TCK_CFG at 0x250 and ending with
> + * GPI_USB_OVER_CURRENT_CFG 0x378
> + */
> +#define GPI_CFG_OFFSET 0x250
> +
> +/*
> + * Pad Control Bits. There are 16 pad control bits for each pin located in 103
> + * 32-bit registers controlling PAD_GPIO[0] to PAD_GPIO[63] followed by
> + * PAD_FUNC_SHARE[0] to PAD_FUNC_SHARE[141]. Odd numbered pins use the upper 16
> + * bit of each register.
> + */
> +#define PAD_SLEW_RATE_MASK GENMASK(11, 9)
> +#define PAD_SLEW_RATE_POS 9
> +#define PAD_BIAS_STRONG_PULL_UP BIT(8)
> +#define PAD_INPUT_ENABLE BIT(7)
> +#define PAD_INPUT_SCHMITT_ENABLE BIT(6)
> +#define PAD_BIAS_DISABLE BIT(5)
> +#define PAD_BIAS_PULL_DOWN BIT(4)
> +#define PAD_BIAS_MASK (PAD_BIAS_STRONG_PULL_UP | \
> + PAD_BIAS_DISABLE | \
> + PAD_BIAS_PULL_DOWN)
> +#define PAD_DRIVE_STRENGTH_MASK GENMASK(3, 0)
> +#define PAD_DRIVE_STRENGTH_POS 0
> +
> +/*
> + * From Section 11, the IO_PADSHARE_SEL register can be programmed to select
> + * one of seven pre-defined multiplexed signal groups on PAD_FUNC_SHARE and
> + * PAD_GPIO pads. This is a global setting.
> + */
> +#define IO_PADSHARE_SEL 0x1a0
> +
> +/*
> + * This just needs to be some number such that when
> + * sfp->gpio.pin_base = PAD_INVALID_GPIO then
> + * starfive_pin_to_gpio(sfp, validpin) is never a valid GPIO number.
> + * That is it should underflow and return something >= NR_GPIOS.
> + */
> +#define PAD_INVALID_GPIO 0x10000
> +
> +/*
> + * The packed pinmux values from the device tree look like this:
> + *
> + * | 31 - 24 | 23 - 16 | 15 - 8 | 7 | 6 | 5 - 0 |
> + * | dout | doen | din | dout rev | doen rev | gpio nr |
> + *
> + * ..but the GPOn_DOUT_CFG and GPOn_DOEN_CFG registers look like this:
> + *
> + * | 31 | 30 - 8 | 7 - 0 |
> + * | dout/doen rev | unused | dout/doen |
> + */
> +static unsigned int starfive_pinmux_to_gpio(u32 v)
> +{
> + return v & (NR_GPIOS - 1);
> +}
> +
> +static u32 starfive_pinmux_to_dout(u32 v)
> +{
> + return ((v & BIT(7)) << (31 - 7)) | ((v >> 24) & GENMASK(7, 0));
> +}
> +
> +static u32 starfive_pinmux_to_doen(u32 v)
> +{
> + return ((v & BIT(6)) << (31 - 6)) | ((v >> 16) & GENMASK(7, 0));
> +}
> +
> +static u32 starfive_pinmux_to_din(u32 v)
> +{
> + return (v >> 8) & GENMASK(7, 0);
> +}
> +
> +/*
> + * The maximum GPIO output current depends on the chosen drive strength:
> + *
> + * DS: 0 1 2 3 4 5 6 7
> + * mA: 14.2 21.2 28.2 35.2 42.2 49.1 56.0 62.8
> + *
> + * After rounding that is 7*DS + 14 mA
> + */
> +static u32 starfive_drive_strength_to_max_mA(u16 ds)
> +{
> + return 7 * ds + 14;
> +}
> +
> +static u16 starfive_drive_strength_from_max_mA(u32 i)
> +{
> + return (clamp(i, 14U, 63U) - 14) / 7;
> +}
> +
> +struct starfive_pinctrl {
> + struct gpio_chip gc;
> + struct pinctrl_gpio_range gpios;
> + raw_spinlock_t lock;
> + void __iomem *base;
> + void __iomem *padctl;
> + struct pinctrl_dev *pctl;
> +};
> +
> +static struct device *starfive_dev(const struct starfive_pinctrl *sfp)
> +{
> + return sfp->gc.parent;
> +}
> +
> +static unsigned int starfive_pin_to_gpio(const struct starfive_pinctrl *sfp,
> + unsigned int pin)
> +{
> + return pin - sfp->gpios.pin_base;
> +}
> +
> +static unsigned int starfive_gpio_to_pin(const struct starfive_pinctrl *sfp,
> + unsigned int gpio)
> +{
> + return sfp->gpios.pin_base + gpio;
> +}
> +
> +static struct starfive_pinctrl *starfive_from_gc(struct gpio_chip *gc)
> +{
> + return container_of(gc, struct starfive_pinctrl, gc);
> +}
> +
> +static struct starfive_pinctrl *starfive_from_irq_data(struct irq_data *d)
> +{
> + return starfive_from_gc(irq_data_get_irq_chip_data(d));
> +}
> +
> +static struct starfive_pinctrl *starfive_from_irq_desc(struct irq_desc *desc)
> +{
> + return starfive_from_gc(irq_desc_get_handler_data(desc));
> +}
> +
> +static const struct pinctrl_pin_desc starfive_pins[] = {
> + PINCTRL_PIN(PAD_GPIO(0), "GPIO[0]"),
> + PINCTRL_PIN(PAD_GPIO(1), "GPIO[1]"),
> + PINCTRL_PIN(PAD_GPIO(2), "GPIO[2]"),
> + PINCTRL_PIN(PAD_GPIO(3), "GPIO[3]"),
> + PINCTRL_PIN(PAD_GPIO(4), "GPIO[4]"),
> + PINCTRL_PIN(PAD_GPIO(5), "GPIO[5]"),
> + PINCTRL_PIN(PAD_GPIO(6), "GPIO[6]"),
> + PINCTRL_PIN(PAD_GPIO(7), "GPIO[7]"),
> + PINCTRL_PIN(PAD_GPIO(8), "GPIO[8]"),
> + PINCTRL_PIN(PAD_GPIO(9), "GPIO[9]"),
> + PINCTRL_PIN(PAD_GPIO(10), "GPIO[10]"),
> + PINCTRL_PIN(PAD_GPIO(11), "GPIO[11]"),
> + PINCTRL_PIN(PAD_GPIO(12), "GPIO[12]"),
> + PINCTRL_PIN(PAD_GPIO(13), "GPIO[13]"),
> + PINCTRL_PIN(PAD_GPIO(14), "GPIO[14]"),
> + PINCTRL_PIN(PAD_GPIO(15), "GPIO[15]"),
> + PINCTRL_PIN(PAD_GPIO(16), "GPIO[16]"),
> + PINCTRL_PIN(PAD_GPIO(17), "GPIO[17]"),
> + PINCTRL_PIN(PAD_GPIO(18), "GPIO[18]"),
> + PINCTRL_PIN(PAD_GPIO(19), "GPIO[19]"),
> + PINCTRL_PIN(PAD_GPIO(20), "GPIO[20]"),
> + PINCTRL_PIN(PAD_GPIO(21), "GPIO[21]"),
> + PINCTRL_PIN(PAD_GPIO(22), "GPIO[22]"),
> + PINCTRL_PIN(PAD_GPIO(23), "GPIO[23]"),
> + PINCTRL_PIN(PAD_GPIO(24), "GPIO[24]"),
> + PINCTRL_PIN(PAD_GPIO(25), "GPIO[25]"),
> + PINCTRL_PIN(PAD_GPIO(26), "GPIO[26]"),
> + PINCTRL_PIN(PAD_GPIO(27), "GPIO[27]"),
> + PINCTRL_PIN(PAD_GPIO(28), "GPIO[28]"),
> + PINCTRL_PIN(PAD_GPIO(29), "GPIO[29]"),
> + PINCTRL_PIN(PAD_GPIO(30), "GPIO[30]"),
> + PINCTRL_PIN(PAD_GPIO(31), "GPIO[31]"),
> + PINCTRL_PIN(PAD_GPIO(32), "GPIO[32]"),
> + PINCTRL_PIN(PAD_GPIO(33), "GPIO[33]"),
> + PINCTRL_PIN(PAD_GPIO(34), "GPIO[34]"),
> + PINCTRL_PIN(PAD_GPIO(35), "GPIO[35]"),
> + PINCTRL_PIN(PAD_GPIO(36), "GPIO[36]"),
> + PINCTRL_PIN(PAD_GPIO(37), "GPIO[37]"),
> + PINCTRL_PIN(PAD_GPIO(38), "GPIO[38]"),
> + PINCTRL_PIN(PAD_GPIO(39), "GPIO[39]"),
> + PINCTRL_PIN(PAD_GPIO(40), "GPIO[40]"),
> + PINCTRL_PIN(PAD_GPIO(41), "GPIO[41]"),
> + PINCTRL_PIN(PAD_GPIO(42), "GPIO[42]"),
> + PINCTRL_PIN(PAD_GPIO(43), "GPIO[43]"),
> + PINCTRL_PIN(PAD_GPIO(44), "GPIO[44]"),
> + PINCTRL_PIN(PAD_GPIO(45), "GPIO[45]"),
> + PINCTRL_PIN(PAD_GPIO(46), "GPIO[46]"),
> + PINCTRL_PIN(PAD_GPIO(47), "GPIO[47]"),
> + PINCTRL_PIN(PAD_GPIO(48), "GPIO[48]"),
> + PINCTRL_PIN(PAD_GPIO(49), "GPIO[49]"),
> + PINCTRL_PIN(PAD_GPIO(50), "GPIO[50]"),
> + PINCTRL_PIN(PAD_GPIO(51), "GPIO[51]"),
> + PINCTRL_PIN(PAD_GPIO(52), "GPIO[52]"),
> + PINCTRL_PIN(PAD_GPIO(53), "GPIO[53]"),
> + PINCTRL_PIN(PAD_GPIO(54), "GPIO[54]"),
> + PINCTRL_PIN(PAD_GPIO(55), "GPIO[55]"),
> + PINCTRL_PIN(PAD_GPIO(56), "GPIO[56]"),
> + PINCTRL_PIN(PAD_GPIO(57), "GPIO[57]"),
> + PINCTRL_PIN(PAD_GPIO(58), "GPIO[58]"),
> + PINCTRL_PIN(PAD_GPIO(59), "GPIO[59]"),
> + PINCTRL_PIN(PAD_GPIO(60), "GPIO[60]"),
> + PINCTRL_PIN(PAD_GPIO(61), "GPIO[61]"),
> + PINCTRL_PIN(PAD_GPIO(62), "GPIO[62]"),
> + PINCTRL_PIN(PAD_GPIO(63), "GPIO[63]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(0), "FUNC_SHARE[0]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(1), "FUNC_SHARE[1]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(2), "FUNC_SHARE[2]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(3), "FUNC_SHARE[3]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(4), "FUNC_SHARE[4]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(5), "FUNC_SHARE[5]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(6), "FUNC_SHARE[6]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(7), "FUNC_SHARE[7]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(8), "FUNC_SHARE[8]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(9), "FUNC_SHARE[9]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(10), "FUNC_SHARE[10]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(11), "FUNC_SHARE[11]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(12), "FUNC_SHARE[12]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(13), "FUNC_SHARE[13]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(14), "FUNC_SHARE[14]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(15), "FUNC_SHARE[15]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(16), "FUNC_SHARE[16]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(17), "FUNC_SHARE[17]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(18), "FUNC_SHARE[18]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(19), "FUNC_SHARE[19]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(20), "FUNC_SHARE[20]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(21), "FUNC_SHARE[21]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(22), "FUNC_SHARE[22]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(23), "FUNC_SHARE[23]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(24), "FUNC_SHARE[24]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(25), "FUNC_SHARE[25]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(26), "FUNC_SHARE[26]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(27), "FUNC_SHARE[27]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(28), "FUNC_SHARE[28]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(29), "FUNC_SHARE[29]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(30), "FUNC_SHARE[30]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(31), "FUNC_SHARE[31]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(32), "FUNC_SHARE[32]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(33), "FUNC_SHARE[33]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(34), "FUNC_SHARE[34]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(35), "FUNC_SHARE[35]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(36), "FUNC_SHARE[36]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(37), "FUNC_SHARE[37]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(38), "FUNC_SHARE[38]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(39), "FUNC_SHARE[39]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(40), "FUNC_SHARE[40]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(41), "FUNC_SHARE[41]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(42), "FUNC_SHARE[42]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(43), "FUNC_SHARE[43]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(44), "FUNC_SHARE[44]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(45), "FUNC_SHARE[45]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(46), "FUNC_SHARE[46]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(47), "FUNC_SHARE[47]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(48), "FUNC_SHARE[48]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(49), "FUNC_SHARE[49]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(50), "FUNC_SHARE[50]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(51), "FUNC_SHARE[51]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(52), "FUNC_SHARE[52]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(53), "FUNC_SHARE[53]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(54), "FUNC_SHARE[54]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(55), "FUNC_SHARE[55]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(56), "FUNC_SHARE[56]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(57), "FUNC_SHARE[57]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(58), "FUNC_SHARE[58]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(59), "FUNC_SHARE[59]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(60), "FUNC_SHARE[60]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(61), "FUNC_SHARE[61]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(62), "FUNC_SHARE[62]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(63), "FUNC_SHARE[63]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(64), "FUNC_SHARE[64]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(65), "FUNC_SHARE[65]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(66), "FUNC_SHARE[66]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(67), "FUNC_SHARE[67]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(68), "FUNC_SHARE[68]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(69), "FUNC_SHARE[69]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(70), "FUNC_SHARE[70]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(71), "FUNC_SHARE[71]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(72), "FUNC_SHARE[72]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(73), "FUNC_SHARE[73]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(74), "FUNC_SHARE[74]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(75), "FUNC_SHARE[75]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(76), "FUNC_SHARE[76]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(77), "FUNC_SHARE[77]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(78), "FUNC_SHARE[78]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(79), "FUNC_SHARE[79]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(80), "FUNC_SHARE[80]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(81), "FUNC_SHARE[81]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(82), "FUNC_SHARE[82]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(83), "FUNC_SHARE[83]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(84), "FUNC_SHARE[84]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(85), "FUNC_SHARE[85]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(86), "FUNC_SHARE[86]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(87), "FUNC_SHARE[87]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(88), "FUNC_SHARE[88]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(89), "FUNC_SHARE[89]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(90), "FUNC_SHARE[90]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(91), "FUNC_SHARE[91]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(92), "FUNC_SHARE[92]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(93), "FUNC_SHARE[93]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(94), "FUNC_SHARE[94]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(95), "FUNC_SHARE[95]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(96), "FUNC_SHARE[96]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(97), "FUNC_SHARE[97]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(98), "FUNC_SHARE[98]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(99), "FUNC_SHARE[99]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(100), "FUNC_SHARE[100]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(101), "FUNC_SHARE[101]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(102), "FUNC_SHARE[102]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(103), "FUNC_SHARE[103]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(104), "FUNC_SHARE[104]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(105), "FUNC_SHARE[105]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(106), "FUNC_SHARE[106]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(107), "FUNC_SHARE[107]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(108), "FUNC_SHARE[108]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(109), "FUNC_SHARE[109]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(110), "FUNC_SHARE[110]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(111), "FUNC_SHARE[111]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(112), "FUNC_SHARE[112]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(113), "FUNC_SHARE[113]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(114), "FUNC_SHARE[114]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(115), "FUNC_SHARE[115]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(116), "FUNC_SHARE[116]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(117), "FUNC_SHARE[117]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(118), "FUNC_SHARE[118]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(119), "FUNC_SHARE[119]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(120), "FUNC_SHARE[120]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(121), "FUNC_SHARE[121]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(122), "FUNC_SHARE[122]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(123), "FUNC_SHARE[123]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(124), "FUNC_SHARE[124]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(125), "FUNC_SHARE[125]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(126), "FUNC_SHARE[126]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(127), "FUNC_SHARE[127]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(128), "FUNC_SHARE[128]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(129), "FUNC_SHARE[129]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(130), "FUNC_SHARE[130]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(131), "FUNC_SHARE[131]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(132), "FUNC_SHARE[132]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(133), "FUNC_SHARE[133]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(134), "FUNC_SHARE[134]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(135), "FUNC_SHARE[135]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(136), "FUNC_SHARE[136]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(137), "FUNC_SHARE[137]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(138), "FUNC_SHARE[138]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(139), "FUNC_SHARE[139]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(140), "FUNC_SHARE[140]"),
> + PINCTRL_PIN(PAD_FUNC_SHARE(141), "FUNC_SHARE[141]"),
> +};
> +
> +#ifdef CONFIG_DEBUG_FS
> +static void starfive_pin_dbg_show(struct pinctrl_dev *pctldev,
> + struct seq_file *s,
> + unsigned int pin)
> +{
> + struct starfive_pinctrl *sfp = pinctrl_dev_get_drvdata(pctldev);
> + unsigned int gpio = starfive_pin_to_gpio(sfp, pin);
> + void __iomem *reg;
> + u32 dout, doen;
> +
> + if (gpio >= NR_GPIOS)
> + return;
> +
> + reg = sfp->base + GPON_DOUT_CFG + 8 * gpio;
> + dout = readl_relaxed(reg + 0x000);
> + doen = readl_relaxed(reg + 0x004);
> +
> + seq_printf(s, "dout=%u%s doen=%u%s",
> + dout & (u32)GENMASK(7, 0), (dout & BIT(31)) ? "r" : "",
> + doen & (u32)GENMASK(7, 0), (doen & BIT(31)) ? "r" : "");
> +}
> +#else
> +#define starfive_pin_dbg_show NULL
> +#endif
> +
> +static int starfive_dt_node_to_map(struct pinctrl_dev *pctldev,
> + struct device_node *np,
> + struct pinctrl_map **maps,
> + unsigned int *num_maps)
> +{
> + struct starfive_pinctrl *sfp = pinctrl_dev_get_drvdata(pctldev);
> + struct device *dev = starfive_dev(sfp);
> + const char **pgnames;
> + struct pinctrl_map *map;
> + struct device_node *child;
> + const char *grpname;
> + int *pins;
> + u32 *pinmux;
> + int nmaps;
> + int ngroups;
> + int ret;
> +
> + nmaps = 0;
> + ngroups = 0;
> + for_each_child_of_node(np, child) {
> + int npinmux = of_property_count_u32_elems(child, "pinmux");
> + int npins = of_property_count_u32_elems(child, "pins");
> +
> + if (npinmux > 0 && npins > 0) {
> + dev_err(dev, "invalid pinctrl group %pOFn.%pOFn: %s\n",
> + np, child, "both pinmux and pins set");
> + of_node_put(child);
> + return -EINVAL;
> + }
> +
> + if (npinmux > 0) {
> + nmaps += 2;
> + } else if (npins > 0) {
> + nmaps += 1;
> + } else {
> + dev_err(dev, "invalid pinctrl group %pOFn.%pOFn: %s\n",
> + np, child, "neither pinmux nor pins set");
> + of_node_put(child);
> + return -EINVAL;
> + }
> + ngroups += 1;
> + }
> +
> + ret = -ENOMEM;
> + pgnames = devm_kcalloc(dev, ngroups, sizeof(*pgnames), GFP_KERNEL);
> + if (!pgnames)
> + return ret;
> +
> + map = kcalloc(nmaps, sizeof(*map), GFP_KERNEL);
> + if (!map)
> + goto free_pgnames;
> +
> + nmaps = 0;
> + ngroups = 0;
> + for_each_child_of_node(np, child) {
> + int npins;
> + int i;
> +
> + ret = -ENOMEM;
> + grpname = devm_kasprintf(dev, GFP_KERNEL, "%s.%s", np->name, child->name);
> + if (!grpname)
> + goto put_child;
> +
> + pgnames[ngroups++] = grpname;
> +
> + if ((npins = of_property_count_u32_elems(child, "pinmux")) > 0) {
> + pins = devm_kcalloc(dev, npins, sizeof(*pins), GFP_KERNEL);
> + if (!pins)
> + goto free_grpname;
> +
> + pinmux = devm_kcalloc(dev, npins, sizeof(*pinmux), GFP_KERNEL);
> + if (!pinmux)
> + goto free_pins;
> +
> + for (i = 0; i < npins; i++) {
> + u32 v;
> +
> + ret = of_property_read_u32_index(child, "pinmux", i, &v);
> + if (ret)
> + goto free_pinmux;
> + pins[i] = starfive_gpio_to_pin(sfp, starfive_pinmux_to_gpio(v));
> + pinmux[i] = v;
> + }
> +
> + map[nmaps].type = PIN_MAP_TYPE_MUX_GROUP;
> + map[nmaps].data.mux.function = np->name;
> + map[nmaps].data.mux.group = grpname;
> + nmaps += 1;
> + } else if ((npins = of_property_count_u32_elems(child, "pins")) > 0) {
> + pins = devm_kcalloc(dev, npins, sizeof(*pins), GFP_KERNEL);
> + if (!pins)
> + goto free_grpname;
> +
> + pinmux = NULL;
> +
> + for (i = 0; i < npins; i++) {
> + u32 v;
> +
> + ret = of_property_read_u32_index(child, "pins", i, &v);
> + if (ret)
> + goto free_pins;
> + pins[i] = v;
> + }
> + } else {
> + ret = -EINVAL;
> + goto free_grpname;
> + }
> +
> + ret = pinctrl_generic_add_group(pctldev, grpname, pins, npins, pinmux);
> + if (ret < 0) {
> + dev_err(dev, "error adding group %pOFn.%pOFn: %d\n",
> + np, child, ret);
> + goto free_pinmux;
> + }
> +
> + ret = pinconf_generic_parse_dt_config(child, pctldev,
> + &map[nmaps].data.configs.configs,
> + &map[nmaps].data.configs.num_configs);
> + if (ret) {
> + dev_err(dev, "invalid pinctrl group %pOFn.%pOFn: %s\n",
> + np, child, "error parsing pin config");
> + goto put_child;
> + }
> +
> + /* don't create a map if there are no pinconf settings */
> + if (map[nmaps].data.configs.num_configs == 0)
> + continue;
> +
> + map[nmaps].type = PIN_MAP_TYPE_CONFIGS_GROUP;
> + map[nmaps].data.configs.group_or_pin = grpname;
> + nmaps += 1;
> + }
> +
> + ret = pinmux_generic_add_function(pctldev, np->name, pgnames, ngroups, NULL);
> + if (ret < 0) {
> + dev_err(dev, "error adding function %pOFn: %d\n", np, ret);
> + goto free_map;
> + }
> +
> + *maps = map;
> + *num_maps = nmaps;
> + return 0;
> +
> +free_pinmux:
> + devm_kfree(dev, pinmux);
> +free_pins:
> + devm_kfree(dev, pins);
> +free_grpname:
> + devm_kfree(dev, grpname);
> +put_child:
> + of_node_put(child);
> +free_map:
> + pinctrl_utils_free_map(pctldev, map, nmaps);
> +free_pgnames:
> + devm_kfree(dev, pgnames);
> + return ret;
> +}
> +
> +static const struct pinctrl_ops starfive_pinctrl_ops = {
> + .get_groups_count = pinctrl_generic_get_group_count,
> + .get_group_name = pinctrl_generic_get_group_name,
> + .get_group_pins = pinctrl_generic_get_group_pins,
> + .pin_dbg_show = starfive_pin_dbg_show,
> + .dt_node_to_map = starfive_dt_node_to_map,
> + .dt_free_map = pinctrl_utils_free_map,
> +};
> +
> +static int starfive_set_mux(struct pinctrl_dev *pctldev,
> + unsigned int fsel, unsigned int gsel)
> +{
> + struct starfive_pinctrl *sfp = pinctrl_dev_get_drvdata(pctldev);
> + struct device *dev = starfive_dev(sfp);
> + const struct group_desc *group;
> + const u32 *pinmux;
> + unsigned int i;
> +
> + group = pinctrl_generic_get_group(pctldev, gsel);
> + if (!group)
> + return -EINVAL;
> +
> + pinmux = group->data;
> + for (i = 0; i < group->num_pins; i++) {
> + u32 v = pinmux[i];
> + unsigned int gpio = starfive_pinmux_to_gpio(v);
> + u32 dout = starfive_pinmux_to_dout(v);
> + u32 doen = starfive_pinmux_to_doen(v);
> + u32 din = starfive_pinmux_to_din(v);
> + void __iomem *reg_dout;
> + void __iomem *reg_doen;
> + void __iomem *reg_din;
> + unsigned long flags;
> +
> + dev_dbg(dev, "GPIO%u: dout=0x%x doen=0x%x din=0x%x\n",
> + gpio, dout, doen, din);
> +
> + reg_dout = sfp->base + GPON_DOUT_CFG + 8 * gpio;
> + reg_doen = sfp->base + GPON_DOEN_CFG + 8 * gpio;
> + if (din != GPI_NONE)
> + reg_din = sfp->base + GPI_CFG_OFFSET + 4 * din;
> + else
> + reg_din = NULL;
> +
> + raw_spin_lock_irqsave(&sfp->lock, flags);
> + writel_relaxed(dout, reg_dout);
> + writel_relaxed(doen, reg_doen);
> + if (reg_din)
> + writel_relaxed(gpio + 2, reg_din);
> + raw_spin_unlock_irqrestore(&sfp->lock, flags);
> + }
> +
> + return 0;
> +}
> +
> +static const struct pinmux_ops starfive_pinmux_ops = {
> + .get_functions_count = pinmux_generic_get_function_count,
> + .get_function_name = pinmux_generic_get_function_name,
> + .get_function_groups = pinmux_generic_get_function_groups,
> + .set_mux = starfive_set_mux,
> + .strict = true,
> +};
> +
> +static u16 starfive_padctl_get(struct starfive_pinctrl *sfp,
> + unsigned int pin)
> +{
> + void __iomem *reg = sfp->padctl + 4 * (pin / 2);
> + int shift = 16 * (pin % 2);
> +
> + return readl_relaxed(reg) >> shift;
> +}
> +
> +static void starfive_padctl_rmw(struct starfive_pinctrl *sfp,
> + unsigned int pin,
> + u16 _mask, u16 _value)
> +{
> + void __iomem *reg = sfp->padctl + 4 * (pin / 2);
> + int shift = 16 * (pin % 2);
> + u32 mask = (u32)_mask << shift;
> + u32 value = (u32)_value << shift;
> + unsigned long flags;
> +
> + dev_dbg(starfive_dev(sfp),
> + "padctl_rmw(%u, 0x%03x, 0x%03x)\n", pin, _mask, _value);
> +
> + raw_spin_lock_irqsave(&sfp->lock, flags);
> + value |= readl_relaxed(reg) & ~mask;
> + writel_relaxed(value, reg);
> + raw_spin_unlock_irqrestore(&sfp->lock, flags);
> +}
> +
> +#define PIN_CONFIG_STARFIVE_STRONG_PULL_UP (PIN_CONFIG_END + 1)
> +
> +static const struct pinconf_generic_params starfive_pinconf_custom_params[] = {
> + { "starfive,strong-pull-up", PIN_CONFIG_STARFIVE_STRONG_PULL_UP, 1 },
> +};
> +
> +#ifdef CONFIG_DEBUG_FS
> +static const struct pin_config_item starfive_pinconf_custom_conf_items[] = {
> + PCONFDUMP(PIN_CONFIG_STARFIVE_STRONG_PULL_UP, "input bias strong pull-up", NULL, false),
> +};
> +
> +static_assert(ARRAY_SIZE(starfive_pinconf_custom_conf_items) ==
> + ARRAY_SIZE(starfive_pinconf_custom_params));
> +#else
> +#define starfive_pinconf_custom_conf_items NULL
> +#endif
> +
> +static int starfive_pinconf_get(struct pinctrl_dev *pctldev,
> + unsigned int pin, unsigned long *config)
> +{
> + struct starfive_pinctrl *sfp = pinctrl_dev_get_drvdata(pctldev);
> + u16 value = starfive_padctl_get(sfp, pin);
> + int param = pinconf_to_config_param(*config);
> + u32 arg;
> + bool enabled;
> +
> + switch (param) {
> + case PIN_CONFIG_BIAS_DISABLE:
> + enabled = value & PAD_BIAS_DISABLE;
> + arg = 0;
> + break;
> + case PIN_CONFIG_BIAS_PULL_DOWN:
> + enabled = value & PAD_BIAS_PULL_DOWN;
> + arg = 1;
> + break;
> + case PIN_CONFIG_BIAS_PULL_UP:
> + enabled = !(value & PAD_BIAS_MASK);
> + arg = 1;
> + break;
> + case PIN_CONFIG_DRIVE_STRENGTH:
> + enabled = value & PAD_DRIVE_STRENGTH_MASK;
> + arg = starfive_drive_strength_to_max_mA(value & PAD_DRIVE_STRENGTH_MASK);
> + break;
> + case PIN_CONFIG_INPUT_ENABLE:
> + enabled = value & PAD_INPUT_ENABLE;
> + arg = enabled;
> + break;
> + case PIN_CONFIG_INPUT_SCHMITT_ENABLE:
> + enabled = value & PAD_INPUT_SCHMITT_ENABLE;
> + arg = enabled;
> + break;
> + case PIN_CONFIG_SLEW_RATE:
> + enabled = value & PAD_SLEW_RATE_MASK;
> + arg = (value & PAD_SLEW_RATE_MASK) >> PAD_SLEW_RATE_POS;
> + break;
> + case PIN_CONFIG_STARFIVE_STRONG_PULL_UP:
> + enabled = value & PAD_BIAS_STRONG_PULL_UP;
> + arg = enabled;
> + break;
> + default:
> + return -ENOTSUPP;
> + }
> +
> + *config = pinconf_to_config_packed(param, arg);
> + return enabled ? 0 : -EINVAL;
> +}
> +
> +static int starfive_pinconf_group_get(struct pinctrl_dev *pctldev,
> + unsigned int gsel, unsigned long *config)
> +{
> + const struct group_desc *group;
> +
> + group = pinctrl_generic_get_group(pctldev, gsel);
> + if (!group)
> + return -EINVAL;
> +
> + return starfive_pinconf_get(pctldev, group->pins[0], config);
> +}
> +
> +static int starfive_pinconf_group_set(struct pinctrl_dev *pctldev,
> + unsigned int gsel,
> + unsigned long *configs,
> + unsigned int num_configs)
> +{
> + struct starfive_pinctrl *sfp = pinctrl_dev_get_drvdata(pctldev);
> + const struct group_desc *group;
> + u16 mask, value;
> + int i;
> +
> + group = pinctrl_generic_get_group(pctldev, gsel);
> + if (!group)
> + return -EINVAL;
> +
> + mask = 0;
> + value = 0;
> + for (i = 0; i < num_configs; i++) {
> + int param = pinconf_to_config_param(configs[i]);
> + u32 arg = pinconf_to_config_argument(configs[i]);
> +
> + switch (param) {
> + case PIN_CONFIG_BIAS_DISABLE:
> + mask |= PAD_BIAS_MASK;
> + value = (value & ~PAD_BIAS_MASK) | PAD_BIAS_DISABLE;
> + break;
> + case PIN_CONFIG_BIAS_PULL_DOWN:
> + if (arg == 0)
> + return -ENOTSUPP;
> + mask |= PAD_BIAS_MASK;
> + value = (value & ~PAD_BIAS_MASK) | PAD_BIAS_PULL_DOWN;
> + break;
> + case PIN_CONFIG_BIAS_PULL_UP:
> + if (arg == 0)
> + return -ENOTSUPP;
> + mask |= PAD_BIAS_MASK;
> + value = value & ~PAD_BIAS_MASK;
> + break;
> + case PIN_CONFIG_DRIVE_STRENGTH:
> + mask |= PAD_DRIVE_STRENGTH_MASK;
> + value = (value & ~PAD_DRIVE_STRENGTH_MASK) |
> + starfive_drive_strength_from_max_mA(arg);
> + break;
> + case PIN_CONFIG_INPUT_ENABLE:
> + mask |= PAD_INPUT_ENABLE;
> + if (arg)
> + value |= PAD_INPUT_ENABLE;
> + else
> + value &= ~PAD_INPUT_ENABLE;
> + break;
> + case PIN_CONFIG_INPUT_SCHMITT_ENABLE:
> + mask |= PAD_INPUT_SCHMITT_ENABLE;
> + if (arg)
> + value |= PAD_INPUT_SCHMITT_ENABLE;
> + else
> + value &= ~PAD_INPUT_SCHMITT_ENABLE;
> + break;
> + case PIN_CONFIG_SLEW_RATE:
> + mask |= PAD_SLEW_RATE_MASK;
> + value = (value & ~PAD_SLEW_RATE_MASK) |
> + ((arg << PAD_SLEW_RATE_POS) & PAD_SLEW_RATE_MASK);
> + break;
> + case PIN_CONFIG_STARFIVE_STRONG_PULL_UP:
> + if (arg) {
> + mask |= PAD_BIAS_MASK;
> + value = (value & ~PAD_BIAS_MASK) |
> + PAD_BIAS_STRONG_PULL_UP;
> + } else {
> + mask |= PAD_BIAS_STRONG_PULL_UP;
> + value = value & ~PAD_BIAS_STRONG_PULL_UP;
> + }
> + break;
> + default:
> + return -ENOTSUPP;
> + }
> + }
> +
> + for (i = 0; i < group->num_pins; i++)
> + starfive_padctl_rmw(sfp, group->pins[i], mask, value);
> +
> + return 0;
> +}
> +
> +#ifdef CONFIG_DEBUG_FS
> +static void starfive_pinconf_dbg_show(struct pinctrl_dev *pctldev,
> + struct seq_file *s, unsigned int pin)
> +{
> + struct starfive_pinctrl *sfp = pinctrl_dev_get_drvdata(pctldev);
> + u16 value = starfive_padctl_get(sfp, pin);
> +
> + seq_printf(s, " (0x%03x)", value);
> +}
> +#else
> +#define starfive_pinconf_dbg_show NULL
> +#endif
> +
> +static const struct pinconf_ops starfive_pinconf_ops = {
> + .pin_config_get = starfive_pinconf_get,
> + .pin_config_group_get = starfive_pinconf_group_get,
> + .pin_config_group_set = starfive_pinconf_group_set,
> + .pin_config_dbg_show = starfive_pinconf_dbg_show,
> + .is_generic = true,
> +};
> +
> +static struct pinctrl_desc starfive_desc = {
> + .name = DRIVER_NAME,
> + .pins = starfive_pins,
> + .npins = ARRAY_SIZE(starfive_pins),
> + .pctlops = &starfive_pinctrl_ops,
> + .pmxops = &starfive_pinmux_ops,
> + .confops = &starfive_pinconf_ops,
> + .owner = THIS_MODULE,
> + .num_custom_params = ARRAY_SIZE(starfive_pinconf_custom_params),
> + .custom_params = starfive_pinconf_custom_params,
> + .custom_conf_items = starfive_pinconf_custom_conf_items,
> +};
> +
> +static int starfive_gpio_request(struct gpio_chip *gc, unsigned int gpio)
> +{
> + return pinctrl_gpio_request(gc->base + gpio);
> +}
> +
> +static void starfive_gpio_free(struct gpio_chip *gc, unsigned int gpio)
> +{
> + pinctrl_gpio_free(gc->base + gpio);
> +}
> +
> +static int starfive_gpio_get_direction(struct gpio_chip *gc, unsigned int gpio)
> +{
> + struct starfive_pinctrl *sfp = starfive_from_gc(gc);
> +
> + if (gpio >= NR_GPIOS)
> + return -EINVAL;
> +
> + /* return GPIO_LINE_DIRECTION_OUT (0) only if doen == GPO_ENABLE (0) */
> + return readl_relaxed(sfp->base + GPON_DOEN_CFG + 8 * gpio) != GPO_ENABLE;
> +}
> +
> +static int starfive_gpio_direction_input(struct gpio_chip *gc,
> + unsigned int gpio)
> +{
> + struct starfive_pinctrl *sfp = starfive_from_gc(gc);
> + void __iomem *doen;
> + unsigned long flags;
> +
> + if (gpio >= NR_GPIOS)
> + return -EINVAL;
> +
> + /* enable input and schmitt trigger */
> + starfive_padctl_rmw(sfp, starfive_gpio_to_pin(sfp, gpio),
> + PAD_INPUT_ENABLE | PAD_INPUT_SCHMITT_ENABLE,
> + PAD_INPUT_ENABLE | PAD_INPUT_SCHMITT_ENABLE);
> +
> + doen = sfp->base + GPON_DOEN_CFG + 8 * gpio;
> + raw_spin_lock_irqsave(&sfp->lock, flags);
> + writel_relaxed(GPO_DISABLE, doen);
> + raw_spin_unlock_irqrestore(&sfp->lock, flags);
> + return 0;
> +}
> +
> +static int starfive_gpio_direction_output(struct gpio_chip *gc,
> + unsigned int gpio, int value)
> +{
> + struct starfive_pinctrl *sfp = starfive_from_gc(gc);
> + void __iomem *dout;
> + void __iomem *doen;
> + unsigned long flags;
> +
> + if (gpio >= NR_GPIOS)
> + return -EINVAL;
> +
> + dout = sfp->base + GPON_DOUT_CFG + 8 * gpio;
> + doen = sfp->base + GPON_DOEN_CFG + 8 * gpio;
> + raw_spin_lock_irqsave(&sfp->lock, flags);
> + writel_relaxed(value, dout);
> + writel_relaxed(GPO_ENABLE, doen);
> + raw_spin_unlock_irqrestore(&sfp->lock, flags);
> +
> + /* disable input, schmitt trigger and bias */
> + starfive_padctl_rmw(sfp, starfive_gpio_to_pin(sfp, gpio),
> + PAD_BIAS_MASK | PAD_INPUT_ENABLE | PAD_INPUT_SCHMITT_ENABLE,
> + PAD_BIAS_DISABLE);
> +
> + return 0;
> +}
> +
> +static int starfive_gpio_get(struct gpio_chip *gc, unsigned int gpio)
> +{
> + struct starfive_pinctrl *sfp = starfive_from_gc(gc);
> + void __iomem *din;
> +
> + if (gpio >= NR_GPIOS)
> + return -EINVAL;
> +
> + din = sfp->base + GPIODIN + 4 * (gpio / 32);
> + return !!(readl_relaxed(din) & BIT(gpio % 32));
> +}
> +
> +static void starfive_gpio_set(struct gpio_chip *gc, unsigned int gpio,
> + int value)
> +{
> + struct starfive_pinctrl *sfp = starfive_from_gc(gc);
> + void __iomem *dout;
> + unsigned long flags;
> +
> + if (gpio >= NR_GPIOS)
> + return;
> +
> + dout = sfp->base + GPON_DOUT_CFG + 8 * gpio;
> + raw_spin_lock_irqsave(&sfp->lock, flags);
> + writel_relaxed(value, dout);
> + raw_spin_unlock_irqrestore(&sfp->lock, flags);
> +}
> +
> +static int starfive_gpio_set_config(struct gpio_chip *gc, unsigned int gpio,
> + unsigned long config)
> +{
> + struct starfive_pinctrl *sfp = starfive_from_gc(gc);
> + u32 arg = pinconf_to_config_argument(config);
> + u16 mask;
> + u16 value;
> +
> + switch (pinconf_to_config_param(config)) {
> + case PIN_CONFIG_BIAS_DISABLE:
> + mask = PAD_BIAS_MASK;
> + value = PAD_BIAS_DISABLE;
> + break;
> + case PIN_CONFIG_BIAS_PULL_DOWN:
> + if (arg == 0)
> + return -ENOTSUPP;
> + mask = PAD_BIAS_MASK;
> + value = PAD_BIAS_PULL_DOWN;
> + break;
> + case PIN_CONFIG_BIAS_PULL_UP:
> + if (arg == 0)
> + return -ENOTSUPP;
> + mask = PAD_BIAS_MASK;
> + value = 0;
> + break;
> + case PIN_CONFIG_DRIVE_PUSH_PULL:
> + return 0;
> + case PIN_CONFIG_INPUT_ENABLE:
> + mask = PAD_INPUT_ENABLE;
> + value = arg ? PAD_INPUT_ENABLE : 0;
> + break;
> + case PIN_CONFIG_INPUT_SCHMITT_ENABLE:
> + mask = PAD_INPUT_SCHMITT_ENABLE;
> + value = arg ? PAD_INPUT_SCHMITT_ENABLE : 0;
> + break;
> + default:
> + return -ENOTSUPP;
> + };
> +
> + starfive_padctl_rmw(sfp, starfive_gpio_to_pin(sfp, gpio), mask, value);
> + return 0;
> +}
> +
> +static int starfive_gpio_add_pin_ranges(struct gpio_chip *gc)
> +{
> + struct starfive_pinctrl *sfp = starfive_from_gc(gc);
> +
> + sfp->gpios.name = sfp->gc.label;
> + sfp->gpios.base = sfp->gc.base;
> + /*
> + * sfp->gpios.pin_base depends on the chosen signal group
> + * and is set in starfive_probe()
> + */
> + sfp->gpios.npins = NR_GPIOS;
> + sfp->gpios.gc = &sfp->gc;
> + pinctrl_add_gpio_range(sfp->pctl, &sfp->gpios);
> + return 0;
> +}
> +
> +static void starfive_irq_ack(struct irq_data *d)
> +{
> + struct starfive_pinctrl *sfp = starfive_from_irq_data(d);
> + irq_hw_number_t gpio = irqd_to_hwirq(d);
> + void __iomem *ic = sfp->base + GPIOIC + 4 * (gpio / 32);
> + u32 mask = BIT(gpio % 32);
> + unsigned long flags;
> +
> + raw_spin_lock_irqsave(&sfp->lock, flags);
> + writel_relaxed(mask, ic);
> + raw_spin_unlock_irqrestore(&sfp->lock, flags);
> +}
> +
> +static void starfive_irq_mask(struct irq_data *d)
> +{
> + struct starfive_pinctrl *sfp = starfive_from_irq_data(d);
> + irq_hw_number_t gpio = irqd_to_hwirq(d);
> + void __iomem *ie = sfp->base + GPIOIE + 4 * (gpio / 32);
> + u32 mask = BIT(gpio % 32);
> + unsigned long flags;
> + u32 value;
> +
> + raw_spin_lock_irqsave(&sfp->lock, flags);
> + value = readl_relaxed(ie) & ~mask;
> + writel_relaxed(value, ie);
> + raw_spin_unlock_irqrestore(&sfp->lock, flags);
> +}
> +
> +static void starfive_irq_mask_ack(struct irq_data *d)
> +{
> + struct starfive_pinctrl *sfp = starfive_from_irq_data(d);
> + irq_hw_number_t gpio = irqd_to_hwirq(d);
> + void __iomem *ie = sfp->base + GPIOIE + 4 * (gpio / 32);
> + void __iomem *ic = sfp->base + GPIOIC + 4 * (gpio / 32);
> + u32 mask = BIT(gpio % 32);
> + unsigned long flags;
> + u32 value;
> +
> + raw_spin_lock_irqsave(&sfp->lock, flags);
> + value = readl_relaxed(ie) & ~mask;
> + writel_relaxed(value, ie);
> + writel_relaxed(mask, ic);
> + raw_spin_unlock_irqrestore(&sfp->lock, flags);
> +}
> +
> +static void starfive_irq_unmask(struct irq_data *d)
> +{
> + struct starfive_pinctrl *sfp = starfive_from_irq_data(d);
> + irq_hw_number_t gpio = irqd_to_hwirq(d);
> + void __iomem *ie = sfp->base + GPIOIE + 4 * (gpio / 32);
> + u32 mask = BIT(gpio % 32);
> + unsigned long flags;
> + u32 value;
> +
> + raw_spin_lock_irqsave(&sfp->lock, flags);
> + value = readl_relaxed(ie) | mask;
> + writel_relaxed(value, ie);
> + raw_spin_unlock_irqrestore(&sfp->lock, flags);
> +}
> +
> +static int starfive_irq_set_type(struct irq_data *d, unsigned int trigger)
> +{
> + struct starfive_pinctrl *sfp = starfive_from_irq_data(d);
> + irq_hw_number_t gpio = irqd_to_hwirq(d);
> + void __iomem *base = sfp->base + 4 * (gpio / 32);
> + u32 mask = BIT(gpio % 32);
> + u32 irq_type, edge_both, polarity;
> + irq_flow_handler_t handler;
> + unsigned long flags;
> +
> + switch (trigger) {
> + case IRQ_TYPE_EDGE_RISING:
> + irq_type = mask; /* 1: edge triggered */
> + edge_both = 0; /* 0: single edge */
> + polarity = mask; /* 1: rising edge */
> + handler = handle_edge_irq;
> + break;
> + case IRQ_TYPE_EDGE_FALLING:
> + irq_type = mask; /* 1: edge triggered */
> + edge_both = 0; /* 0: single edge */
> + polarity = 0; /* 0: falling edge */
> + handler = handle_edge_irq;
> + break;
> + case IRQ_TYPE_EDGE_BOTH:
> + irq_type = mask; /* 1: edge triggered */
> + edge_both = mask; /* 1: both edges */
> + polarity = 0; /* 0: ignored */
> + handler = handle_edge_irq;
> + break;
> + case IRQ_TYPE_LEVEL_HIGH:
> + irq_type = 0; /* 0: level triggered */
> + edge_both = 0; /* 0: ignored */
> + polarity = mask; /* 1: high level */
> + handler = handle_level_irq;
> + break;
> + case IRQ_TYPE_LEVEL_LOW:
> + irq_type = 0; /* 0: level triggered */
> + edge_both = 0; /* 0: ignored */
> + polarity = 0; /* 0: low level */
> + handler = handle_level_irq;
> + break;
> + default:
> + irq_set_handler_locked(d, handle_bad_irq);
> + return -EINVAL;
> + }
> +
> + irq_set_handler_locked(d, handler);
> +
> + raw_spin_lock_irqsave(&sfp->lock, flags);
> + irq_type |= readl_relaxed(base + GPIOIS) & ~mask;
> + writel_relaxed(irq_type, base + GPIOIS);
> + edge_both |= readl_relaxed(base + GPIOIBE) & ~mask;
> + writel_relaxed(edge_both, base + GPIOIBE);
> + polarity |= readl_relaxed(base + GPIOIEV) & ~mask;
> + writel_relaxed(polarity, base + GPIOIEV);
> + raw_spin_unlock_irqrestore(&sfp->lock, flags);
> + return 0;
> +}
> +
> +static struct irq_chip starfive_irq_chip = {
> + .irq_ack = starfive_irq_ack,
> + .irq_mask = starfive_irq_mask,
> + .irq_mask_ack = starfive_irq_mask_ack,
> + .irq_unmask = starfive_irq_unmask,
> + .irq_set_type = starfive_irq_set_type,
> + .flags = IRQCHIP_SET_TYPE_MASKED,
> +};
> +
> +static void starfive_gpio_irq_handler(struct irq_desc *desc)
> +{
> + struct starfive_pinctrl *sfp = starfive_from_irq_desc(desc);
> + struct irq_chip *chip = irq_desc_get_chip(desc);
> + unsigned long mis;
> + unsigned int pin;
> +
> + chained_irq_enter(chip, desc);
> +
> + mis = readl_relaxed(sfp->base + GPIOMIS + 0);
> + for_each_set_bit(pin, &mis, 32)
> + generic_handle_domain_irq(sfp->gc.irq.domain, pin);
> +
> + mis = readl_relaxed(sfp->base + GPIOMIS + 4);
> + for_each_set_bit(pin, &mis, 32)
> + generic_handle_domain_irq(sfp->gc.irq.domain, pin + 32);
> +
> + chained_irq_exit(chip, desc);
> +}
> +
> +static int starfive_gpio_init_hw(struct gpio_chip *gc)
> +{
> + struct starfive_pinctrl *sfp = starfive_from_gc(gc);
> +
> + /* mask all GPIO interrupts */
> + writel(0, sfp->base + GPIOIE + 0);
> + writel(0, sfp->base + GPIOIE + 4);

Woudln't 0 in GPIOIE mean mask is disabled for all interrupts?

In other words, wouldn't this enable all the interrupts?

Thanks,
Drew