Re: [PATCH v2 11/16] dt-bindings: pinctrl: Add StarFive JH7100 bindings

Rob Herring
2021-10-29T14:44:46Z

On Fri, Oct 29, 2021 at 8:00 AM Emil Renner Berthing <kernel@esmil.dk> wrote:
>
> On Fri, 29 Oct 2021 at 03:50, Rob Herring <robh@kernel.org> wrote:
> > On Thu, Oct 21, 2021 at 07:42:18PM +0200, Emil Renner Berthing wrote:
> > > +patternProperties:
> > > + '-[0-9]*$':
> >
> > Can you make this more specific. As-is, '-' and 'foo-' are valid.
> >
> > > + type: object
> > > + patternProperties:
> > > + '-pins*$':
> >
> > So foo-pinsssssss is okay? Drop the '*' or use ? if you intend to
> > support 'foo-pin'.
>
> Ah, thanks. Both this and the pattern above was taken from
> pinctrl/mediatek,mt6779-pinctrl.yaml if anyone feels like fixing that
> too. I see now that '-[0-9]+$' and '-pins$' is more common. I'll just
> use that.
>
> > > + type: object
> > > + description: |
> > > + A pinctrl node should contain at least one subnode representing the
> > > + pinctrl groups available on the machine. Each subnode will list the
> > > + pins it needs, and how they should be configured, with regard to
> > > + muxer configuration, bias, input enable/disable, input schmitt
> > > + trigger enable/disable, slew-rate and drive strength.
> > > + $ref: "/schemas/pinctrl/pincfg-node.yaml"
> > > +
> > > + properties:
> > > + pins:
> > > + description: |
> > > + The list of pin identifiers that properties in the node apply to.
> > > + This should be set using either the PAD_GPIO or PAD_FUNC_SHARE
> > > + macro. Either this or "pinmux" has to be specified.
> > > +
> > > + pinmux:
> > > + description: |
> > > + The list of GPIO identifiers and their mux settings that
> > > + properties in the node apply to. This should be set using the
> > > + GPIOMUX macro. Either this or "pins" has to be specified.
> > > +
> > > + bias-disable: true
> > > +
> > > + bias-pull-up:
> > > + type: boolean
> >
> > Already has a type. Need to reference the common schema.
>
> Right, but the common schema specifies one of boolean or uint32. Is
> there a way to reference that, but still say that this binding
> supports only the boolean version?

Okay, then keep this.

Rob