From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B48C433F5 for ; Fri, 22 Oct 2021 01:00:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25F0A610FF for ; Fri, 22 Oct 2021 01:00:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232374AbhJVBCb (ORCPT ); Thu, 21 Oct 2021 21:02:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232165AbhJVBC1 (ORCPT ); Thu, 21 Oct 2021 21:02:27 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2318FC061766 for ; Thu, 21 Oct 2021 18:00:11 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id e189-20020a2569c6000000b005be95530997so2258769ybc.6 for ; Thu, 21 Oct 2021 18:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=tfzEGlsF6ydFjGENDgk5t9ypFeU6Wu831H4Ly6n5KZI=; b=eqKNefxFjpWs8RvYPeXzjU0dbNjtKAURlt+n7C1E+dDYcU2CXBKq4sNEPdwfHitpbA gVtNaYSndbHcp8s8+KQpc8IxdcDgolmAWyOMsQtjZkXeGjxLJffTJmDLAD9/tnVeNd32 ZOraYVgjj+c1iRewsphawp86ettzfHEwgvKIlahJ+3t7To1RzJ7EhqkETembo4cLnOln pG9kOOk+0qG9cxDQuQo9aeQeYy8yI4YZA8aRbUFEYtz3xD2ZAM/4hPuJsjRCsS8ztfJc r53LxcIa1xEZgN9LUZ6BsMfsngORw/nECDK4jABkk+4Y+vJZSd7jb0fIB408cFAMk3WI 3i6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=tfzEGlsF6ydFjGENDgk5t9ypFeU6Wu831H4Ly6n5KZI=; b=pIO9LE7w+ob21j30bnE6hbQLJAIp2akSs2Jm7ce/+sOCQuigwC93zoL4shBwLkWZWP cRsm/I5uBozdKJuYfwx8Xp6md9Jk+veA++o3aZDEWNsHmFPL4Z6ORHzkFquHaX/KrSmJ 5YRLtET8htYAaOW3iOFrlIjtOuFzMPXcW6it/qYPFCcstqpn99sZwxx51EXHgDu6RUkG jiKkMdk26+5UbCsSGxmAqDHrERHKXTX9Co43N2V6ep8zkCRcClwSg45FESs+zfsAI707 gydquj5aZqZmQ0EZhkL+bazMPWETO2afcDr6i6aZIwIpf9XS1MgPBRbjgI9Kq3utAdGR xu7A== X-Gm-Message-State: AOAM530tZ86EwfAc3OQOLppcy8pAgln172GQ+VhjXx767/Xl/ikics5/ XjoPqn6WZpjOFP0GWjpsC4ezwQtQnX8= X-Google-Smtp-Source: ABdhPJzZgE7RiGa+gowciszx8dDcOkW5McLZTjeLbkkkAniObK4rJlJduXorUjVGqX0ZnLXHOP8DLiIzo1o= X-Received: from seanjc798194.pdx.corp.google.com ([2620:15c:90:200:db63:c8c0:4e69:449d]) (user=seanjc job=sendgmr) by 2002:a05:6902:50c:: with SMTP id x12mr10492149ybs.139.1634864410395; Thu, 21 Oct 2021 18:00:10 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 21 Oct 2021 18:00:03 -0700 In-Reply-To: <20211022010005.1454978-1-seanjc@google.com> Message-Id: <20211022010005.1454978-2-seanjc@google.com> Mime-Version: 1.0 References: <20211022010005.1454978-1-seanjc@google.com> X-Mailer: git-send-email 2.33.0.1079.g6e70778dc9-goog Subject: [PATCH 1/3] KVM: x86/mmu: Drop a redundant, broken remote TLB flush From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Maxim Levitsky , "Maciej S . Szmigiero" , Ben Gardon Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A recent commit to fix the calls to kvm_flush_remote_tlbs_with_address() in kvm_zap_gfn_range() inadvertantly added yet another flush instead of fixing the existing flush. Drop the redundant flush, and fix the params for the existing flush. Fixes: 2822da446640 ("KVM: x86/mmu: fix parameters to kvm_flush_remote_tlbs_with_address") Cc: Maxim Levitsky Cc: Maciej S. Szmigiero Signed-off-by: Sean Christopherson --- arch/x86/kvm/mmu/mmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index c6ddb042b281..f82b192bba0b 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -5709,13 +5709,11 @@ void kvm_zap_gfn_range(struct kvm *kvm, gfn_t gfn_start, gfn_t gfn_end) for (i = 0; i < KVM_ADDRESS_SPACE_NUM; i++) flush = kvm_tdp_mmu_zap_gfn_range(kvm, i, gfn_start, gfn_end, flush); - if (flush) - kvm_flush_remote_tlbs_with_address(kvm, gfn_start, - gfn_end - gfn_start); } if (flush) - kvm_flush_remote_tlbs_with_address(kvm, gfn_start, gfn_end); + kvm_flush_remote_tlbs_with_address(kvm, gfn_start, + gfn_end - gfn_start); kvm_dec_notifier_count(kvm, gfn_start, gfn_end); -- 2.33.0.1079.g6e70778dc9-goog