Re: [PATCH v2 1/3] serial: 8250_pci: Refactor the loop in pci_ite887x_init()

Jiri Slaby
2021-10-26T06:52:12Z

On 26. 10. 21, 8:44, Greg Kroah-Hartman wrote:
> On Tue, Oct 26, 2021 at 07:26:18AM +0200, Jiri Slaby wrote:
>> On 22. 10. 21, 15:51, Andy Shevchenko wrote:
>>> The loop can be refactored by using ARRAY_SIZE() instead of NULL terminator.
>>> This reduces code base and makes it easier to read and understand.
>>
>> Why don't we have array_for_each() BTW?
>>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> Reviewed-by: Jiri Slaby <jslaby@kernel.org>
>
> And now my emails are bouncing as you typed your address incorrectly :(

Sorry for that. My WM currently crashes when I use key shortcuts (key
input in plasma is not implemented under wayland). So I had to write
those manually and screwed up. Let me improve my workflow now.

thanks,
--
js
suse labs