From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7F08C433F5 for ; Sat, 23 Oct 2021 09:20:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81C2761057 for ; Sat, 23 Oct 2021 09:20:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230203AbhJWJXH (ORCPT ); Sat, 23 Oct 2021 05:23:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:35700 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229818AbhJWJXF (ORCPT ); Sat, 23 Oct 2021 05:23:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C18116105A; Sat, 23 Oct 2021 09:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634980846; bh=+59WMV3Dlz1AP4Ei8SuUj51Ty+lB2iDdY5m0xFBMPdo=; h=From:To:Cc:Subject:Date:From; b=mOHfaMtFi2+smdUAbwKDIe5GC78AMa3rGA/wzQkXQsHJpSAXvA/Bqw0i9N/7gTh8z KDBkCyZl07zMvUXvS7q1sTvBzU2p26aY7Bu1g+0QEZRPX+8a+mUJc32IRFsHMdB2vj x96LAeBoQtfNIYEj1N1cmx8wP7t0IYSTkHvW/5kcp/Dhy5T5AzlgARKtDXsYre/J9W +5QjBpwFe9ylCtVAMqnysmU6Leh8t/wwYOMxRl8hlzW/qZ4XNss/NQjGOVufDiV7v+ IxfPhm1WTnmoVcBp+JMvUfAsPVIRTtivpk2fNbQi9Vq4KLjwb6qX9/D0RnLWXc7QjR Eq+Y7nQTlKKYg== From: Oded Gabbay To: linux-kernel@vger.kernel.org Cc: Ohad Sharabi Subject: [PATCH 1/2] habanalabs: modify wait for boot fit in dynamic FW load Date: Sat, 23 Oct 2021 12:20:40 +0300 Message-Id: <20211023092041.2364497-1-ogabbay@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ohad Sharabi In the dynamic FW load protocol the boot status is updated to "Ready to Boot" once uboot is active. Polling on other boot status values is a residue of code duplication from the static protocol and should be removed. Signed-off-by: Ohad Sharabi Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/firmware_if.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/misc/habanalabs/common/firmware_if.c b/drivers/misc/habanalabs/common/firmware_if.c index 4e68fb9d2a6b..025707a21882 100644 --- a/drivers/misc/habanalabs/common/firmware_if.c +++ b/drivers/misc/habanalabs/common/firmware_if.c @@ -2060,7 +2060,6 @@ static int hl_fw_dynamic_wait_for_boot_fit_active(struct hl_device *hdev, hdev, le32_to_cpu(dyn_loader->comm_desc.cpu_dyn_regs.cpu_boot_status), status, - (status == CPU_BOOT_STATUS_NIC_FW_RDY) || (status == CPU_BOOT_STATUS_READY_TO_BOOT), FW_CPU_STATUS_POLL_INTERVAL_USEC, dyn_loader->wait_for_bl_timeout); -- 2.25.1