From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
linuxarm@huawei.com, mauro.chehab@huawei.com,
"Krzysztof Wilczyński" <kw@linux.com>,
"Binghui Wang" <wangbinghui@hisilicon.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Rob Herring" <robh@kernel.org>,
"Xiaowei Song" <songxiaowei@hisilicon.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v15 02/13] PCI: kirin: Add support for a PHY layer
Date: Mon, 25 Oct 2021 09:52:54 +0100 [thread overview]
Message-ID: <20211025095254.522c1da6@sal.lan> (raw)
In-Reply-To: <3919b668-cf6a-ffda-0115-c2a94750e56a@ti.com>
Hi Kishon,
Em Mon, 25 Oct 2021 13:44:57 +0530
Kishon Vijay Abraham I <kishon@ti.com> escreveu:
> Hi Mauro,
> > +
> > +static const struct of_device_id kirin_pcie_match[] = {
> > + {
> > + .compatible = "hisilicon,kirin960-pcie",
> > + .data = (void *)PCIE_KIRIN_INTERNAL_PHY
> > + },
>
> Where is PCIE_KIRIN_EXTERNAL_PHY used?
See:
[PATCH v15 06/13] PCI: kirin: Add Kirin 970 compatible
https://lore.kernel.org/all/ac8c730c0300b90d96bdaaf387d458d8949241a9.1634812676.git.mchehab+huawei@kernel.org/
Basically, Kirin 970 (and any other devices that would use the same
driver) should also use PCIE_KIRIN_EXTERNAL_PHY and place the PHY
driver inside drivers/phy, instead of hardcoding it at the driver.
The Kirin 970 PHY driver was already merged at linux-next:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/phy/hisilicon/phy-hi3670-pcie.c
Regards,
Mauro
next prev parent reply other threads:[~2021-10-25 8:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 10:45 [PATCH v15 00/13] Add support for Hikey 970 PCIe Mauro Carvalho Chehab
2021-10-21 10:45 ` [PATCH v15 01/13] PCI: kirin: Reorganize the PHY logic inside the driver Mauro Carvalho Chehab
2021-11-04 21:48 ` Bjorn Helgaas
2021-10-21 10:45 ` [PATCH v15 02/13] PCI: kirin: Add support for a PHY layer Mauro Carvalho Chehab
2021-10-25 8:14 ` Kishon Vijay Abraham I
2021-10-25 8:52 ` Mauro Carvalho Chehab [this message]
2021-10-25 8:56 ` Kishon Vijay Abraham I
2021-10-21 10:45 ` [PATCH v15 03/13] PCI: kirin: Use regmap for APB registers Mauro Carvalho Chehab
2021-10-21 10:45 ` [PATCH v15 04/13] PCI: kirin: Add support for bridge slot DT schema Mauro Carvalho Chehab
2021-11-02 16:06 ` Bjorn Helgaas
2021-11-02 17:44 ` Mauro Carvalho Chehab
2021-11-02 22:08 ` Pali Rohár
2021-11-04 15:36 ` Rob Herring
2021-11-04 17:27 ` Mauro Carvalho Chehab
2021-10-21 10:45 ` [PATCH v15 05/13] PCI: kirin: Give more time for PERST# reset to finish Mauro Carvalho Chehab
2021-10-21 10:45 ` [PATCH v15 06/13] PCI: kirin: Add Kirin 970 compatible Mauro Carvalho Chehab
2021-10-21 10:45 ` [PATCH v15 07/13] PCI: kirin: Add MODULE_* macros Mauro Carvalho Chehab
2021-10-21 10:45 ` [PATCH v15 08/13] PCI: kirin: Allow building it as a module Mauro Carvalho Chehab
2021-10-21 10:45 ` [PATCH v15 09/13] PCI: kirin: Add power_off support for Kirin 960 PHY Mauro Carvalho Chehab
2021-10-21 10:45 ` [PATCH v15 10/13] PCI: kirin: Move the power-off code to a common routine Mauro Carvalho Chehab
2021-10-21 10:45 ` [PATCH v15 11/13] PCI: kirin: Disable clkreq during poweroff sequence Mauro Carvalho Chehab
2021-10-21 10:45 ` [PATCH v15 12/13] PCI: kirin: De-init the dwc driver Mauro Carvalho Chehab
2021-10-21 10:45 ` [PATCH v15 13/13] PCI: kirin: Allow removing the driver Mauro Carvalho Chehab
2021-10-31 20:55 ` Pali Rohár
2021-10-21 12:17 ` [PATCH v15 00/13] Add support for Hikey 970 PCIe Lorenzo Pieralisi
2021-10-26 17:17 ` Lorenzo Pieralisi
2021-10-27 7:24 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025095254.522c1da6@sal.lan \
--to=mchehab+huawei@kernel.org \
--cc=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=mauro.chehab@huawei.com \
--cc=robh@kernel.org \
--cc=songxiaowei@hisilicon.com \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox