From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44B9CC433F5 for ; Mon, 25 Oct 2021 13:52:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2967660230 for ; Mon, 25 Oct 2021 13:52:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232987AbhJYNyv (ORCPT ); Mon, 25 Oct 2021 09:54:51 -0400 Received: from mga04.intel.com ([192.55.52.120]:47230 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233002AbhJYNyr (ORCPT ); Mon, 25 Oct 2021 09:54:47 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10147"; a="228416461" X-IronPort-AV: E=Sophos;i="5.87,180,1631602800"; d="scan'208";a="228416461" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2021 06:52:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,180,1631602800"; d="scan'208";a="634746875" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 25 Oct 2021 06:52:01 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 289C7321; Mon, 25 Oct 2021 16:52:01 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , Arnaud Pouliquen , linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby Subject: [PATCH v1 5/5] tty: rpmsg: Define tty name via constant string literal Date: Mon, 25 Oct 2021 16:51:48 +0300 Message-Id: <20211025135148.53944-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211025135148.53944-1-andriy.shevchenko@linux.intel.com> References: <20211025135148.53944-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Driver uses already twice the same string literal. Define it in one place, so every user will have this name consistent. Signed-off-by: Andy Shevchenko --- drivers/tty/rpmsg_tty.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/tty/rpmsg_tty.c b/drivers/tty/rpmsg_tty.c index 4bee6c5bbb53..dae2a4e44f38 100644 --- a/drivers/tty/rpmsg_tty.c +++ b/drivers/tty/rpmsg_tty.c @@ -18,6 +18,7 @@ #include #include +#define RPMSG_TTY_NAME "ttyRPMSG" #define MAX_TTY_RPMSG 32 static DEFINE_IDR(tty_idr); /* tty instance id */ @@ -172,7 +173,7 @@ static int rpmsg_tty_probe(struct rpmsg_device *rpdev) dev_set_drvdata(dev, cport); - dev_dbg(dev, "New channel: 0x%x -> 0x%x : ttyRPMSG%d\n", + dev_dbg(dev, "New channel: 0x%x -> 0x%x: " RPMSG_TTY_NAME "%d\n", rpdev->src, rpdev->dst, cport->id); return 0; @@ -224,7 +225,7 @@ static int __init rpmsg_tty_init(void) return PTR_ERR(rpmsg_tty_driver); rpmsg_tty_driver->driver_name = "rpmsg_tty"; - rpmsg_tty_driver->name = "ttyRPMSG"; + rpmsg_tty_driver->name = RPMSG_TTY_NAME; rpmsg_tty_driver->major = 0; rpmsg_tty_driver->type = TTY_DRIVER_TYPE_CONSOLE; -- 2.33.0