Re: [PATCH v14 00/39] NVIDIA Tegra power management patches for 5.17

Ulf Hansson
2021-10-27T16:01:42Z

On Tue, 26 Oct 2021 at 00:45, Dmitry Osipenko <digetx@gmail.com> wrote:
>
> This series adds runtime PM support to Tegra drivers and enables core
> voltage scaling for Tegra20/30 SoCs, resolving overheating troubles.
>
> All patches in this series are interdependent and should go via Tegra tree
> for simplicity.
>
> Changelog:
>
> v14: - Fixed missing runtime PM syncing on removal of drivers, which was
> spotted by Ulf Hansson in v13.
>
> - clk-device driver now resumes RPM on system suspend instead of
> preparing clock which it backs. This was suggested by Ulf Hansson.
>
> - clk-device driver now syncs power domain performance unconditionally
> during driver's probe time since GENPD API allows to do this now.
> It was spotted by Ulf Hansson.
>
> - Added new "Enable runtime PM during OPP state-syncing" patch, which
> allows drivers to sync state at any time. Previously drivers were
> obligated to take care of enabling RPM at the "right" time.
>
> - Moved runtime PM initialization/uninitialization of DRM drivers that
> use host1x channel to host1x client init/deinit phase. I noticed that
> there is UAF problem because RPM-suspend callback waits until channel
> is idling and channel is already released/freed during driver's removal
> phase.
>
> - Added system suspend support to the new NVDEC DRM driver.
>
> - Added missing pm_runtime_mark_last_busy() to DRM driver.
>
> - Corrected VDE GENPD patch which previously made video decoder clock
> always-enabled by mistake if legacy PD code path was used. It was
> spotted while we were testing VDE on Tegra114 that doesn't support
> GENPD yet.
>
> - Added ack from Peter Chen to the USB patch that he gave to v13.
>
> - Changed OPP table names in accordance to the new naming scheme
> required by the recent core OPP binding.
>
> - Added 500MHz memory OPP entry used by ASUS Transformer tablets.

Besides those minor nitpicks/questions that I have sent for patch1 and
patch29, the series looks good to me!

Feel free to add, for the whole series:

Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe