* [PATCH] drivers: mtd: Fixed breaking list in __mtd_del_partition.
@ 2021-10-25 20:57 Andreas Oetken
2021-10-26 7:31 ` Miquel Raynal
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Oetken @ 2021-10-25 20:57 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, linux-kernel, Andreas Oetken
Not the child partition should be removed from the partition list
but the partition itself. Otherwise the partition list gets broken
and any subsequent remove operations leads to a kernel panic.
Signed-off-by: Andreas Oetken <andreas.oetken@siemens-energy.com>
---
drivers/mtd/mtdpart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index 95d47422bbf20..5725818fa199f 100644
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -313,7 +313,7 @@ static int __mtd_del_partition(struct mtd_info *mtd)
if (err)
return err;
- list_del(&child->part.node);
+ list_del(&mtd->part.node);
free_partition(mtd);
return 0;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: mtd: Fixed breaking list in __mtd_del_partition.
2021-10-25 20:57 [PATCH] drivers: mtd: Fixed breaking list in __mtd_del_partition Andreas Oetken
@ 2021-10-26 7:31 ` Miquel Raynal
0 siblings, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2021-10-26 7:31 UTC (permalink / raw)
To: Andreas Oetken
Cc: Richard Weinberger, Vignesh Raghavendra, linux-mtd, linux-kernel,
Andreas Oetken
Hi Andreas,
ennoerlangen@gmail.com wrote on Mon, 25 Oct 2021 22:57:24 +0200:
> Not the child partition should be removed from the partition list
> but the partition itself. Otherwise the partition list gets broken
> and any subsequent remove operations leads to a kernel panic.
>
Can you please Add a couple of Fixes: + Cc: stable tags?
> Signed-off-by: Andreas Oetken <andreas.oetken@siemens-energy.com>
> ---
> drivers/mtd/mtdpart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
> index 95d47422bbf20..5725818fa199f 100644
> --- a/drivers/mtd/mtdpart.c
> +++ b/drivers/mtd/mtdpart.c
> @@ -313,7 +313,7 @@ static int __mtd_del_partition(struct mtd_info *mtd)
> if (err)
> return err;
>
> - list_del(&child->part.node);
> + list_del(&mtd->part.node);
> free_partition(mtd);
>
> return 0;
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] drivers: mtd: Fixed breaking list in __mtd_del_partition.
@ 2021-10-26 8:46 Andreas Oetken
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Oetken @ 2021-10-26 8:46 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, linux-kernel, Andreas Oetken
Not the child partition should be removed from the partition list
but the partition itself. Otherwise the partition list gets broken
and any subsequent remove operations leads to a kernel panic.
Signed-off-by: Andreas Oetken <andreas.oetken@siemens-energy.com>
---
drivers/mtd/mtdpart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index 95d47422bbf20..5725818fa199f 100644
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -313,7 +313,7 @@ static int __mtd_del_partition(struct mtd_info *mtd)
if (err)
return err;
- list_del(&child->part.node);
+ list_del(&mtd->part.node);
free_partition(mtd);
return 0;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-26 8:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-25 20:57 [PATCH] drivers: mtd: Fixed breaking list in __mtd_del_partition Andreas Oetken
2021-10-26 7:31 ` Miquel Raynal
-- strict thread matches above, loose matches on Subject: below --
2021-10-26 8:46 Andreas Oetken
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox