public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kerneljasonxing@gmail.com
To: davem@davemloft.net, kuba@kernel.org, alobakin@pm.me,
	jonathan.lemon@gmail.com, willemb@google.com, pabeni@redhat.com,
	vvs@virtuozzo.com, cong.wang@bytedance.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kerneljasonxing@gmail.com, Jason Xing <xingwanli@kuaishou.com>
Subject: [PATCH net] net: gro: set the last skb->next to NULL when it get merged
Date: Tue, 26 Oct 2021 21:18:59 +0800	[thread overview]
Message-ID: <20211026131859.59114-1-kerneljasonxing@gmail.com> (raw)

From: Jason Xing <xingwanli@kuaishou.com>

Setting the @next of the last skb to NULL to prevent the panic in future
when someone does something to the last of the gro list but its @next is
invalid.

For example, without the fix (commit: ece23711dd95), a panic could happen
with the clsact loaded when skb is redirected and then validated in
validate_xmit_skb_list() which could access the error addr of the @next
of the last skb. Thus, "general protection fault" would appear after that.

Signed-off-by: Jason Xing <xingwanli@kuaishou.com>
---
 net/core/skbuff.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 2170bea..7b248f1 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -4396,6 +4396,7 @@ int skb_gro_receive(struct sk_buff *p, struct sk_buff *skb)
 		skb_shinfo(p)->frag_list = skb;
 	else
 		NAPI_GRO_CB(p)->last->next = skb;
+	skb->next = NULL;
 	NAPI_GRO_CB(p)->last = skb;
 	__skb_header_release(skb);
 	lp = p;
-- 
1.8.3.1


             reply	other threads:[~2021-10-26 13:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 13:18 kerneljasonxing [this message]
2021-10-27  7:23 ` [PATCH net] net: gro: set the last skb->next to NULL when it get merged Jason Xing
2021-10-27  8:07   ` Jason Xing
2021-10-27  8:56     ` Jason Xing
2021-10-27 12:40       ` Yunsheng Lin
2021-10-27 12:54         ` Jason Xing
2021-10-27 13:57           ` Jason Xing
2021-10-27 19:25     ` Eric Dumazet
2021-10-27 19:20 ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211026131859.59114-1-kerneljasonxing@gmail.com \
    --to=kerneljasonxing@gmail.com \
    --cc=alobakin@pm.me \
    --cc=cong.wang@bytedance.com \
    --cc=davem@davemloft.net \
    --cc=jonathan.lemon@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vvs@virtuozzo.com \
    --cc=willemb@google.com \
    --cc=xingwanli@kuaishou.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox