From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 642B5C433EF for ; Tue, 26 Oct 2021 13:36:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43F5C60EC0 for ; Tue, 26 Oct 2021 13:36:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236262AbhJZNiZ (ORCPT ); Tue, 26 Oct 2021 09:38:25 -0400 Received: from mga11.intel.com ([192.55.52.93]:50906 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236234AbhJZNiX (ORCPT ); Tue, 26 Oct 2021 09:38:23 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10148"; a="227358787" X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="227358787" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2021 06:34:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="497339112" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 26 Oct 2021 06:34:54 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3F8C5E7; Tue, 26 Oct 2021 16:34:54 +0300 (EEST) From: Andy Shevchenko To: Greg Kroah-Hartman , Andy Shevchenko , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jiri Slaby Subject: [PATCH v3 2/2] serial: 8250_pci: Remove empty stub pci_quatech_exit() Date: Tue, 26 Oct 2021 16:34:52 +0300 Message-Id: <20211026133452.61657-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211026133452.61657-1-andriy.shevchenko@linux.intel.com> References: <20211026133452.61657-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ->exit() callback is checked for presence anyway, no need to have an empty stub. Signed-off-by: Andy Shevchenko --- v3: no changes drivers/tty/serial/8250/8250_pci.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c index 1c2eb44e9c33..5d43de143f33 100644 --- a/drivers/tty/serial/8250/8250_pci.c +++ b/drivers/tty/serial/8250/8250_pci.c @@ -1298,10 +1298,6 @@ static int pci_quatech_setup(struct serial_private *priv, return pci_default_setup(priv, board, port, idx); } -static void pci_quatech_exit(struct pci_dev *dev) -{ -} - static int pci_default_setup(struct serial_private *priv, const struct pciserial_board *board, struct uart_8250_port *port, int idx) @@ -2176,7 +2172,6 @@ static struct pci_serial_quirk pci_serial_quirks[] = { .subdevice = PCI_ANY_ID, .init = pci_quatech_init, .setup = pci_quatech_setup, - .exit = pci_quatech_exit, }, /* * Panacom -- 2.33.0