* [PATCH] ima/evm: mark evm_fixmode as __ro_after_init
@ 2021-10-26 22:43 Austin Kim
2021-10-28 0:27 ` Mimi Zohar
0 siblings, 1 reply; 3+ messages in thread
From: Austin Kim @ 2021-10-26 22:43 UTC (permalink / raw)
To: zohar, jmorris, serge
Cc: linux-integrity, linux-security-module, linux-kernel, austin.kim,
kernel-team
From: Austin Kim <austin.kim@lge.com>
evm_fixmode global variable is never modified
outside initcalls, so declaring it with __ro_after_init is better.
Signed-off-by: Austin Kim <austin.kim@lge.com>
---
security/integrity/evm/evm_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/integrity/evm/evm_main.c b/security/integrity/evm/evm_main.c
index 1c8435dfabee..08f907382c61 100644
--- a/security/integrity/evm/evm_main.c
+++ b/security/integrity/evm/evm_main.c
@@ -78,7 +78,7 @@ static struct xattr_list evm_config_default_xattrnames[] = {
LIST_HEAD(evm_config_xattrnames);
-static int evm_fixmode;
+static int evm_fixmode __ro_after_init;
static int __init evm_set_fixmode(char *str)
{
if (strncmp(str, "fix", 3) == 0)
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ima/evm: mark evm_fixmode as __ro_after_init
2021-10-26 22:43 [PATCH] ima/evm: mark evm_fixmode as __ro_after_init Austin Kim
@ 2021-10-28 0:27 ` Mimi Zohar
2021-10-28 1:48 ` Austin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Mimi Zohar @ 2021-10-28 0:27 UTC (permalink / raw)
To: Austin Kim, jmorris, serge
Cc: linux-integrity, linux-security-module, linux-kernel, austin.kim,
kernel-team
Hi Austin,
The subject line should be just "evm:".
On Tue, 2021-10-26 at 23:43 +0100, Austin Kim wrote:
> From: Austin Kim <austin.kim@lge.com>
>
> evm_fixmode global variable is never modified
> outside initcalls, so declaring it with __ro_after_init is better.
Please properly format the text. From
Documentation/process/submitting-patches.rst:
- The body of the explanation, line wrapped at 75 columns, which will
be copied to the permanent changelog to describe this patch.
>
> Signed-off-by: Austin Kim <austin.kim@lge.com>
Otherwise,
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ima/evm: mark evm_fixmode as __ro_after_init
2021-10-28 0:27 ` Mimi Zohar
@ 2021-10-28 1:48 ` Austin Kim
0 siblings, 0 replies; 3+ messages in thread
From: Austin Kim @ 2021-10-28 1:48 UTC (permalink / raw)
To: Mimi Zohar
Cc: James Morris, Serge E. Hallyn, linux-integrity,
linux-security-module, Linux Kernel Mailing List,
김동현, kernel-team
Hello Mimi,
2021년 10월 28일 (목) 오전 9:27, Mimi Zohar <zohar@linux.ibm.com>님이 작성:
>
> Hi Austin,
>
> The subject line should be just "evm:".
>
> On Tue, 2021-10-26 at 23:43 +0100, Austin Kim wrote:
> > From: Austin Kim <austin.kim@lge.com>
> >
> > evm_fixmode global variable is never modified
> > outside initcalls, so declaring it with __ro_after_init is better.
>
> Please properly format the text. From
> Documentation/process/submitting-patches.rst:
>
> - The body of the explanation, line wrapped at 75 columns, which will
> be copied to the permanent changelog to describe this patch.
Thanks for feedback.
let me resend the patch after updating "subject line" and checking text-format.
BR,
Austin Kim
>
> >
> > Signed-off-by: Austin Kim <austin.kim@lge.com>
>
> Otherwise,
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-28 1:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-26 22:43 [PATCH] ima/evm: mark evm_fixmode as __ro_after_init Austin Kim
2021-10-28 0:27 ` Mimi Zohar
2021-10-28 1:48 ` Austin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox