* [PATCH] crash_dump: fix boolreturn.cocci warning
@ 2021-10-20 8:39 cgel.zte
2021-10-20 10:15 ` Simon Horman
2021-10-29 9:31 ` Baoquan He
0 siblings, 2 replies; 3+ messages in thread
From: cgel.zte @ 2021-10-20 8:39 UTC (permalink / raw)
To: dyoung; +Cc: bhe, vgoyal, kexec, linux-kernel, Changcheng Deng, Zeal Robot
From: Changcheng Deng <deng.changcheng@zte.com.cn>
./include/linux/crash_dump.h: 119: 50-51: WARNING: return of 0/1 in
function 'is_kdump_kernel' with return type bool
Return statements in functions returning bool should use true/false
instead of 1/0.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
include/linux/crash_dump.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
index 0c547d866f1e..979c26176c1d 100644
--- a/include/linux/crash_dump.h
+++ b/include/linux/crash_dump.h
@@ -116,7 +116,7 @@ extern void register_vmcore_cb(struct vmcore_cb *cb);
extern void unregister_vmcore_cb(struct vmcore_cb *cb);
#else /* !CONFIG_CRASH_DUMP */
-static inline bool is_kdump_kernel(void) { return 0; }
+static inline bool is_kdump_kernel(void) { return false; }
#endif /* CONFIG_CRASH_DUMP */
/* Device Dump information to be filled by drivers */
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crash_dump: fix boolreturn.cocci warning
2021-10-20 8:39 [PATCH] crash_dump: fix boolreturn.cocci warning cgel.zte
@ 2021-10-20 10:15 ` Simon Horman
2021-10-29 9:31 ` Baoquan He
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2021-10-20 10:15 UTC (permalink / raw)
To: cgel.zte
Cc: dyoung, bhe, vgoyal, kexec, linux-kernel, Changcheng Deng,
Zeal Robot
On Wed, Oct 20, 2021 at 08:39:05AM +0000, cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> ./include/linux/crash_dump.h: 119: 50-51: WARNING: return of 0/1 in
> function 'is_kdump_kernel' with return type bool
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crash_dump: fix boolreturn.cocci warning
2021-10-20 8:39 [PATCH] crash_dump: fix boolreturn.cocci warning cgel.zte
2021-10-20 10:15 ` Simon Horman
@ 2021-10-29 9:31 ` Baoquan He
1 sibling, 0 replies; 3+ messages in thread
From: Baoquan He @ 2021-10-29 9:31 UTC (permalink / raw)
To: cgel.zte
Cc: dyoung, vgoyal, kexec, akpm, linux-kernel, Changcheng Deng,
Zeal Robot
On 10/20/21 at 08:39am, cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> ./include/linux/crash_dump.h: 119: 50-51: WARNING: return of 0/1 in
> function 'is_kdump_kernel' with return type bool
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Looks good to me, thanks.
Acked-by: Baoquan He <bhe@redhat.com>
> ---
> include/linux/crash_dump.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index 0c547d866f1e..979c26176c1d 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -116,7 +116,7 @@ extern void register_vmcore_cb(struct vmcore_cb *cb);
> extern void unregister_vmcore_cb(struct vmcore_cb *cb);
>
> #else /* !CONFIG_CRASH_DUMP */
> -static inline bool is_kdump_kernel(void) { return 0; }
> +static inline bool is_kdump_kernel(void) { return false; }
> #endif /* CONFIG_CRASH_DUMP */
>
> /* Device Dump information to be filled by drivers */
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-29 9:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-20 8:39 [PATCH] crash_dump: fix boolreturn.cocci warning cgel.zte
2021-10-20 10:15 ` Simon Horman
2021-10-29 9:31 ` Baoquan He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox