From: Arnd Bergmann <arnd@kernel.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Dillon Min <dillon.minfei@gmail.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Arnd Bergmann <arnd@arndb.de>,
Alexandre Courbot <acourbot@chromium.org>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Yunfei Dong <yunfei.dong@mediatek.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] media: stm32-dma2d: fix Kconfig dependencies
Date: Fri, 29 Oct 2021 13:50:22 +0200 [thread overview]
Message-ID: <20211029115036.1365378-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
The new DMA2D accidentally allowed compile-testing configurations
that clearly cannot link:
ld.lld: error: undefined symbol: v4l_vb2q_enable_media_source
>>> referenced by videobuf2-core.c
>>> media/common/videobuf2/videobuf2-core.o:(vb2_core_streamon) in archive drivers/built-in.a
ld.lld: error: undefined symbol: v4l2_device_register
>>> referenced by dma2d.c
>>> media/platform/stm32/dma2d/dma2d.o:(dma2d_probe) in archive drivers/built-in.a
ld.lld: error: undefined symbol: video_device_alloc
>>> referenced by dma2d.c
>>> media/platform/stm32/dma2d/dma2d.o:(dma2d_probe) in archive drivers/built-in.a
ld.lld: error: undefined symbol: v4l2_m2m_init
>>> referenced by dma2d.c
>>> media/platform/stm32/dma2d/dma2d.o:(dma2d_probe) in archive drivers/built-in.a
Tighten the dependencies to only allow test builds when VIDEO_V4L2
is available, but keep it possible for non-stm32 targets.
Fixes: bdbbd511ef0c ("media: stm32-dma2d: STM32 DMA2D driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/media/platform/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 68f16aef8754..9fbdba0fd1e7 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -494,7 +494,8 @@ endif # VIDEO_STI_DELTA
config VIDEO_STM32_DMA2D
tristate "STM32 Chrom-Art Accelerator (DMA2D)"
- depends on (VIDEO_DEV && VIDEO_V4L2 && ARCH_STM32) || COMPILE_TEST
+ depends on VIDEO_DEV && VIDEO_V4L2
+ depends on ARCH_STM32 || COMPILE_TEST
select VIDEOBUF2_DMA_CONTIG
select V4L2_MEM2MEM_DEV
help
--
2.29.2
reply other threads:[~2021-10-29 11:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211029115036.1365378-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=acourbot@chromium.org \
--cc=arnd@arndb.de \
--cc=dillon.minfei@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox