From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AD87C433F5 for ; Mon, 1 Nov 2021 09:19:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64CDD610EA for ; Mon, 1 Nov 2021 09:19:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232158AbhKAJWE (ORCPT ); Mon, 1 Nov 2021 05:22:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:57524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231977AbhKAJVW (ORCPT ); Mon, 1 Nov 2021 05:21:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0396B610A8; Mon, 1 Nov 2021 09:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1635758329; bh=NEeR/4H6phk62Byll9jW7Rk8yfiqZg1vR0vlIyVky4U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ceV4agGIGUvYtVYWe8fRQEypKnJL1E1nD8eivgQlWbJNFMqxOl6StVxyVIIoR940g 3vdgdNZ9Mw5q+jk1HNyHz+dU/Bjo2Kkb7jSD/3j7sN02FovKX48yhVrnrXQPyWJg0/ 92XjdGqeabgoKOlX9GzS7m8bKSyOK6VRe69zBAC0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xin Long , Marcelo Ricardo Leitner , Jakub Kicinski , Sasha Levin Subject: [PATCH 4.4 16/17] sctp: use init_tag from inithdr for ABORT chunk Date: Mon, 1 Nov 2021 10:17:19 +0100 Message-Id: <20211101082444.340670234@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211101082440.664392327@linuxfoundation.org> References: <20211101082440.664392327@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xin Long [ Upstream commit 4f7019c7eb33967eb87766e0e4602b5576873680 ] Currently Linux SCTP uses the verification tag of the existing SCTP asoc when failing to process and sending the packet with the ABORT chunk. This will result in the peer accepting the ABORT chunk and removing the SCTP asoc. One could exploit this to terminate a SCTP asoc. This patch is to fix it by always using the initiate tag of the received INIT chunk for the ABORT chunk to be sent. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Xin Long Acked-by: Marcelo Ricardo Leitner Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/sctp/sm_statefuns.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index a9ba6f2bb8c8..b83f90bb1a6e 100644 --- a/net/sctp/sm_statefuns.c +++ b/net/sctp/sm_statefuns.c @@ -6027,6 +6027,7 @@ static struct sctp_packet *sctp_ootb_pkt_new(struct net *net, * yet. */ switch (chunk->chunk_hdr->type) { + case SCTP_CID_INIT: case SCTP_CID_INIT_ACK: { sctp_initack_chunk_t *initack; -- 2.33.0