From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gaston Gonzalez <gascoar@gmail.com>
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org,
nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de,
ojaswin98@gmail.com, amarjargal16@gmail.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: vchiq_core: get rid of typedef
Date: Mon, 1 Nov 2021 17:48:53 +0300 [thread overview]
Message-ID: <20211101144853.GE2914@kadam> (raw)
In-Reply-To: <20211029200012.45986-1-gascoar@gmail.com>
On Fri, Oct 29, 2021 at 05:00:12PM -0300, Gaston Gonzalez wrote:
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> index 3e50910ecba3..53a98949b294 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> @@ -74,9 +74,7 @@
> ((fourcc) >> 8) & 0xff, \
> (fourcc) & 0xff
>
> -typedef u32 BITSET_T;
> -
> -static_assert((sizeof(BITSET_T) * 8) == 32);
> +static_assert((sizeof(u32) * 8) == 32);
This assert is now pointless and should be removed. Your patch has
already been applied so you can send a new follow on patch to do that.
Also the BITSET_* stuff should be converted to normal kernel bitfield
macros which use unsigned long pointers and set/clear/test_bit(). This
conversion is slightly more complicated so don't worry about it if you
don't want to.
regards,
dan carpenter
prev parent reply other threads:[~2021-11-01 14:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 20:00 [PATCH v2] staging: vchiq_core: get rid of typedef Gaston Gonzalez
2021-11-01 14:48 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101144853.GE2914@kadam \
--to=dan.carpenter@oracle.com \
--cc=amarjargal16@gmail.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gascoar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
--cc=ojaswin98@gmail.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox