From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBCABC433EF for ; Wed, 3 Nov 2021 06:41:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEF9261139 for ; Wed, 3 Nov 2021 06:41:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231911AbhKCGnm (ORCPT ); Wed, 3 Nov 2021 02:43:42 -0400 Received: from verein.lst.de ([213.95.11.211]:58411 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230152AbhKCGng (ORCPT ); Wed, 3 Nov 2021 02:43:36 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 66A3C68AA6; Wed, 3 Nov 2021 07:40:56 +0100 (CET) Date: Wed, 3 Nov 2021 07:40:56 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Christoph Hellwig , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Zhenyu Wang , Zhi Wang , intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 28/29] drm/i915/gvt: convert to use vfio_register_group_dev() Message-ID: <20211103064056.GA30216@lst.de> References: <20211102070601.155501-1-hch@lst.de> <20211102070601.155501-29-hch@lst.de> <20211102164136.GI2744544@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211102164136.GI2744544@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 02, 2021 at 01:41:36PM -0300, Jason Gunthorpe wrote: > On Tue, Nov 02, 2021 at 08:06:00AM +0100, Christoph Hellwig wrote: > > This is straightforward conversion, the intel_vgpu already has a pointer > > to the vfio_dev, which can be replaced with the embedded structure and > > we can replace all the mdev_get_drvdata() with a simple container_of(). > > This should be using vfio_register_emulated_iommu_dev(), right? Yes, once rebased to 5.16-rc where this function appears.