From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Karolina Drobnik <karolinadrobnik@gmail.com>,
outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
forest@alittletooquiet.net, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/8] staging: vt6655: Introduce `idx` temporary variable
Date: Fri, 5 Nov 2021 15:51:45 +0300 [thread overview]
Message-ID: <20211105125144.GA2001@kadam> (raw)
In-Reply-To: <2dd81d1a081562dc38bf9d8c6c73b432c5c5f496.camel@perches.com>
On Thu, Nov 04, 2021 at 07:33:36AM -0700, Joe Perches wrote:
> On Thu, 2021-11-04 at 15:09 +0300, Dan Carpenter wrote:
> > On Mon, Nov 01, 2021 at 02:31:59PM +0000, Karolina Drobnik wrote:
> > > Add a local variable to store `MISCFIFO_SYNDATA_IDX` offset.
> > > This change helps in shortening the lines in `rf.c` that
> > > are deemed too long by checkpatch.pl.
> > >
> >
> > I started reviewing the v1 patch but I should have been reviewing this
> > patchset. Please don't do this. Leave the constant as a constant so
> > we don't have to look it up.
>
> It's just an intermediate step to use idx++.
> Personally, I'd combine patches to add and use idx++ directly.
Yep. I saw that when I reviewed the later patches. This patch should
be combined with those as you say.
regards,
dan carpenter
next prev parent reply other threads:[~2021-11-05 12:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 14:31 [PATCH v2 0/8] subject: staging: vt6655: Fix line wrapping in `RFvWriteWakeProgSyn` Karolina Drobnik
2021-11-01 14:31 ` [PATCH v2 1/8] staging: vt6655: Introduce `idx` temporary variable Karolina Drobnik
2021-11-04 12:09 ` Dan Carpenter
2021-11-04 14:33 ` Joe Perches
2021-11-05 12:51 ` Dan Carpenter [this message]
2021-11-01 14:32 ` [PATCH v2 2/8] staging: vt6655: Use incrementation in `idx` Karolina Drobnik
2021-11-04 12:15 ` Dan Carpenter
2021-11-04 13:00 ` Dan Carpenter
2021-11-04 14:44 ` Joe Perches
2021-11-04 17:40 ` Dan Carpenter
2021-11-01 14:32 ` [PATCH v2 3/8] staging: vt6655: Remove unused `i` increments Karolina Drobnik
2021-11-04 13:38 ` Dan Carpenter
2021-11-08 9:57 ` Karolina Drobnik
2021-11-08 10:16 ` Dan Carpenter
2021-11-01 14:32 ` [PATCH v2 4/8] staging: vt6655: Rewrite conditional in AL7320 initialization Karolina Drobnik
2021-11-01 14:32 ` [PATCH v2 5/8] staging: vt6655: Rename `RFvWriteWakeProgSyn` function Karolina Drobnik
2021-11-01 14:32 ` [PATCH v2 6/8] staging: vt6655: Update comment for `rf_write_wake_prog_syn` Karolina Drobnik
2021-11-01 14:32 ` [PATCH v2 7/8] staging: vt6655: Delete bogus check for `init_count` in AL2230 Karolina Drobnik
2021-11-01 14:32 ` [PATCH v2 8/8] staging: vt6655: Delete bogus check for `init_count` in AL7230 Karolina Drobnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211105125144.GA2001@kadam \
--to=dan.carpenter@oracle.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=karolinadrobnik@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox