From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33BE1C433F5 for ; Fri, 5 Nov 2021 13:32:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13A5E6112E for ; Fri, 5 Nov 2021 13:32:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233115AbhKENf2 (ORCPT ); Fri, 5 Nov 2021 09:35:28 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:47694 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232832AbhKENfZ (ORCPT ); Fri, 5 Nov 2021 09:35:25 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 4B0841C0BAC; Fri, 5 Nov 2021 14:32:44 +0100 (CET) Date: Fri, 5 Nov 2021 14:32:43 +0100 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Rob Herring , Kefeng Wang , "Russell King (Oracle)" Subject: Re: [PATCH 5.10 13/16] ARM: 9120/1: Revert "amba: make use of -1 IRQs warn" Message-ID: <20211105133243.GA9809@amd> References: <20211104141159.561284732@linuxfoundation.org> <20211104141200.023521604@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="x+6KMIRAuhnl3hBn" Content-Disposition: inline In-Reply-To: <20211104141200.023521604@linuxfoundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --x+6KMIRAuhnl3hBn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Wang Kefeng >=20 > commit eb4f756915875b0ea0757751cd29841f0504d547 upstream. >=20 > After commit 77a7300abad7 ("of/irq: Get rid of NO_IRQ usage"), > no irq case has been removed, irq_of_parse_and_map() will return > 0 in all cases when get error from parse and map an interrupt into > linux virq space. >=20 > amba_device_register() is only used on no-DT initialization, see > s3c64xx_pl080_init() arch/arm/mach-s3c/pl080.c > ep93xx_init_devices() arch/arm/mach-ep93xx/core.c >=20 > They won't set -1 to irq[0], so no need the warn. AFAICT this does not fix any bug. It is simply a WARN that can not trigger. Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --x+6KMIRAuhnl3hBn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmGFMnoACgkQMOfwapXb+vIuqgCcCYEXcUd8W6Y+3oJW/E0tzcxB uA0AoKM3aNRsq8rkuuVovD9Q0k8O36mJ =csIP -----END PGP SIGNATURE----- --x+6KMIRAuhnl3hBn--