Re: [PATCH 4/4] bq25890_charger: Enable continuous conversion for ADC at charging

Sebastian Reichel
2021-11-15T15:24:26Z

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

Hi,

On Sun, Nov 07, 2021 at 09:48:38PM +0100, Hans de Goede wrote:
> Hi,
>
> On 11/7/21 21:20, Yauhen Kharuzhy wrote:
> > Instead of one shot run of ADC at beginning of charging, run continuous
> > conversion to ensure that all charging-related values are monitored
> > properly (input voltage, input current, themperature etc.).
> >
> > Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>
>
> Thank you for finding this! This explains why all the ADC returned
> values like current_now where 0 when charging, I thought this was
> just something which was only supported while not charging, heh.
>
> As before, the patch subject prefix should be: "power: supply: bq25890: "
>
> Otherwise the patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Sebastian, this really is a pure bug-fix patch, any chance you
> can pick this up for a future 5.16-rc# pull-req ?
>
> Regards,
>
> Hans

Thanks, queued to power-supply's fixes branch.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]