Re: [PATCH 4/4] bq25890_charger: Enable continuous conversion for ADC at charging

Hans de Goede
2021-11-15T15:41:42Z

Hi,

On 11/15/21 16:23, Sebastian Reichel wrote:
> Hi,
>
> On Sun, Nov 07, 2021 at 09:48:38PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 11/7/21 21:20, Yauhen Kharuzhy wrote:
>>> Instead of one shot run of ADC at beginning of charging, run continuous
>>> conversion to ensure that all charging-related values are monitored
>>> properly (input voltage, input current, themperature etc.).
>>>
>>> Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>
>>
>> Thank you for finding this! This explains why all the ADC returned
>> values like current_now where 0 when charging, I thought this was
>> just something which was only supported while not charging, heh.
>>
>> As before, the patch subject prefix should be: "power: supply: bq25890: "
>>
>> Otherwise the patch looks good to me:
>>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>
>> Sebastian, this really is a pure bug-fix patch, any chance you
>> can pick this up for a future 5.16-rc# pull-req ?
>>
>> Regards,
>>
>> Hans
>
> Thanks, queued to power-supply's fixes branch.

Thank you.

Note I also added this to my:

[PATCH v2 00/20] power-suppy/i2c/extcon: Fix charger setup on Xiaomi Mi Pad 2 and Lenovo Yogabook

Series, together with 2 of the 3 other patches from this series
(with some minor fixes applied to one of them).

So you can skip:

[PATCH v2 02/20] power: supply: bq25890: Fix ADC continuous conversion setting when charging

from that series (I reworded the commit msg subject a bit,
but it is the exact same patch).

If I end up doing a v3, I'll drop this patch.

Regards,

Hans