public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Sven Schnelle <svens@stackframe.org>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Helge Deller <deller@gmx.de>
Subject: [RFC PATCH deller-parisc] hpmc_addr can be static
Date: Mon, 8 Nov 2021 18:35:46 +0800	[thread overview]
Message-ID: <20211108103546.GA42682@0ee8734adabc> (raw)
In-Reply-To: <202111081813.jnmMVQMT-lkp@intel.com>

drivers/tty/sysrq.c:150:15: warning: symbol 'hpmc_addr' was not declared. Should it be static?

Fixes: c743202c8e5c ("hpmc trigger")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 sysrq.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index b8a982f12ba9f..c95b22fe3cd26 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -147,7 +147,7 @@ static const struct sysrq_key_op sysrq_unraw_op = {
 #define sysrq_unraw_op (*(const struct sysrq_key_op *)NULL)
 #endif /* CONFIG_VT */
 
-unsigned long *hpmc_addr;
+static unsigned long *hpmc_addr;
 static void sysrq_handle_crash(int key)
 {
 	/* release the RCU read lock before crashing */

      reply	other threads:[~2021-11-08 10:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 10:35 [deller-parisc:HPMC_and_TOC_on_c8000 1/3] drivers/tty/sysrq.c:150:15: sparse: sparse: symbol 'hpmc_addr' was not declared. Should it be static? kernel test robot
2021-11-08 10:35 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211108103546.GA42682@0ee8734adabc \
    --to=lkp@intel.com \
    --cc=deller@gmx.de \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=svens@stackframe.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox