From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Jimmy Kizito <Jimmy.Kizito@amd.com>, Aric Cyr <aric.cyr@amd.com>,
Meenakshikumar Somasundaram <meenakshikumar.somasundaram@amd.com>,
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Sasha Levin <sashal@kernel.org>,
harry.wentland@amd.com, sunpeng.li@amd.com,
christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
daniel@ffwll.ch, Jun.Lei@amd.com, wenjing.liu@amd.com,
Anson.Jacob@amd.com, Wesley.Chalmers@amd.com,
george.shen@amd.com, Jerry.Zuo@amd.com, stylon.wang@amd.com,
nicholas.kazlauskas@amd.com, vladimir.stempen@amd.com,
qingqing.zhuo@amd.com, Samson.Tam@amd.com,
agustin.gutierrez@amd.com, wyatt.wood@amd.com,
paul.hsieh@amd.com, hanghong.ma@amd.com,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH AUTOSEL 5.14 027/138] drm/amd/display: Fix null pointer dereference for encoders
Date: Mon, 8 Nov 2021 12:44:53 -0500 [thread overview]
Message-ID: <20211108174644.1187889-27-sashal@kernel.org> (raw)
In-Reply-To: <20211108174644.1187889-1-sashal@kernel.org>
From: Jimmy Kizito <Jimmy.Kizito@amd.com>
[ Upstream commit 60f39edd897ea134a4ddb789a6795681691c3183 ]
[Why]
Links which are dynamically assigned link encoders have their link
encoder set to NULL.
[How]
Check that a pointer to a link_encoder object is non-NULL before using
it.
Reviewed-by: Aric Cyr <aric.cyr@amd.com>
Reviewed-by: Meenakshikumar Somasundaram <meenakshikumar.somasundaram@amd.com>
Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Jimmy Kizito <Jimmy.Kizito@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index 3c8da3665a274..7b418f3f9291c 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -4681,7 +4681,7 @@ enum dc_status dp_set_fec_ready(struct dc_link *link, bool ready)
link_enc->funcs->fec_set_ready(link_enc, true);
link->fec_state = dc_link_fec_ready;
} else {
- link_enc->funcs->fec_set_ready(link->link_enc, false);
+ link_enc->funcs->fec_set_ready(link_enc, false);
link->fec_state = dc_link_fec_not_ready;
dm_error("dpcd write failed to set fec_ready");
}
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
index 75fa4adcf5f40..da7c906ba5eb5 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
@@ -1522,7 +1522,7 @@ void dcn10_power_down_on_boot(struct dc *dc)
for (i = 0; i < dc->link_count; i++) {
struct dc_link *link = dc->links[i];
- if (link->link_enc->funcs->is_dig_enabled &&
+ if (link->link_enc && link->link_enc->funcs->is_dig_enabled &&
link->link_enc->funcs->is_dig_enabled(link->link_enc) &&
dc->hwss.power_down) {
dc->hwss.power_down(dc);
--
2.33.0
next prev parent reply other threads:[~2021-11-09 1:06 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 17:44 [PATCH AUTOSEL 5.14 001/138] dma-buf: WARN on dmabuf release with pending attachments Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 002/138] drm: panel-orientation-quirks: Update the Lenovo Ideapad D330 quirk (v2) Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 003/138] drm: panel-orientation-quirks: Add quirk for KD Kurio Smart C15200 2-in-1 Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 004/138] drm: panel-orientation-quirks: Add quirk for the Samsung Galaxy Book 10.6 Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 005/138] Bluetooth: sco: Fix lock_sock() blockage by memcpy_from_msg() Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 006/138] Bluetooth: fix use-after-free error in lock_sock_nested() Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 007/138] drm/panel-orientation-quirks: add Valve Steam Deck Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 008/138] rcutorture: Avoid problematic critical section nesting on PREEMPT_RT Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 009/138] platform/x86: wmi: do not fail if disabling fails Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 010/138] MIPS: lantiq: dma: add small delay after reset Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 011/138] MIPS: lantiq: dma: reset correct number of channel Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 012/138] locking/lockdep: Avoid RCU-induced noinstr fail Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 013/138] net: sched: update default qdisc visibility after Tx queue cnt changes Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 014/138] ACPI: resources: Add DMI-based legacy IRQ override quirk Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 015/138] rcu-tasks: Move RTGS_WAIT_CBS to beginning of rcu_tasks_kthread() loop Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 016/138] smackfs: Fix use-after-free in netlbl_catmap_walk() Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 017/138] ath11k: Align bss_chan_info structure with firmware Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 018/138] crypto: aesni - check walk.nbytes instead of err Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 019/138] NET: IPV4: fix error "do not initialise globals to 0" Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 020/138] x86/mm/64: Improve stack overflow warnings Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 021/138] x86: Increase exception stack sizes Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 022/138] mwifiex: Run SET_BSS_MODE when changing from P2P to STATION vif-type Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 023/138] mwifiex: Properly initialize private structure on interface type changes Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 024/138] spi: Check we have a spi_device_id for each DT compatible Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 025/138] fscrypt: allow 256-bit master keys with AES-256-XTS Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 026/138] drm/amdgpu: Fix MMIO access page fault Sasha Levin
2021-11-08 17:44 ` Sasha Levin [this message]
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 028/138] selftests: net: fib_nexthops: Wait before checking reported idle time Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 029/138] leds: trigger: use RCU to protect the led_cdevs list Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 030/138] ath11k: Avoid reg rules update during firmware recovery Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 031/138] ath11k: add handler for scan event WMI_SCAN_EVENT_DEQUEUED Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 032/138] ath11k: Change DMA_FROM_DEVICE to DMA_TO_DEVICE when map reinjected packets Sasha Levin
2021-11-08 17:44 ` [PATCH AUTOSEL 5.14 033/138] ath10k: high latency fixes for beacon buffer Sasha Levin
2021-11-08 17:45 ` [PATCH AUTOSEL 5.14 034/138] octeontx2-pf: Enable promisc/allmulti match MCAM entries Sasha Levin
2021-11-08 17:45 ` [PATCH AUTOSEL 5.14 035/138] media: mt9p031: Fix corrupted frame after restarting stream Sasha Levin
2021-11-08 17:45 ` [PATCH AUTOSEL 5.14 036/138] media: netup_unidvb: handle interrupt properly according to the firmware Sasha Levin
2021-11-08 17:45 ` [PATCH AUTOSEL 5.14 037/138] media: atomisp: Fix error handling in probe Sasha Levin
2021-11-08 17:45 ` [PATCH AUTOSEL 5.14 038/138] media: stm32: Potential NULL pointer dereference in dcmi_irq_thread() Sasha Levin
2021-11-08 17:45 ` [PATCH AUTOSEL 5.14 039/138] media: uvcvideo: Set capability in s_param Sasha Levin
2021-11-08 17:45 ` [PATCH AUTOSEL 5.14 040/138] media: uvcvideo: Return -EIO for control errors Sasha Levin
2021-11-08 17:45 ` [PATCH AUTOSEL 5.14 041/138] media: uvcvideo: Set unique vdev name based in type Sasha Levin
2021-11-08 17:45 ` [PATCH AUTOSEL 5.14 042/138] media: vidtv: Fix memory leak in remove Sasha Levin
2021-11-08 17:45 ` [PATCH AUTOSEL 5.14 043/138] media: s5p-mfc: fix possible null-pointer dereference in s5p_mfc_probe() Sasha Levin
2021-11-08 17:45 ` [PATCH AUTOSEL 5.14 044/138] media: s5p-mfc: Add checking to s5p_mfc_probe() Sasha Levin
2021-11-08 17:45 ` [PATCH AUTOSEL 5.14 045/138] media: videobuf2: rework vb2_mem_ops API Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211108174644.1187889-27-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=Anson.Jacob@amd.com \
--cc=Jerry.Zuo@amd.com \
--cc=Jimmy.Kizito@amd.com \
--cc=Jun.Lei@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Samson.Tam@amd.com \
--cc=Wesley.Chalmers@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=agustin.gutierrez@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aric.cyr@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=george.shen@amd.com \
--cc=hanghong.ma@amd.com \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=meenakshikumar.somasundaram@amd.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=paul.hsieh@amd.com \
--cc=qingqing.zhuo@amd.com \
--cc=stable@vger.kernel.org \
--cc=stylon.wang@amd.com \
--cc=sunpeng.li@amd.com \
--cc=vladimir.stempen@amd.com \
--cc=wenjing.liu@amd.com \
--cc=wyatt.wood@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox