From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Nadezda Lutovinova <lutovinova@ispras.ru>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Sasha Levin <sashal@kernel.org>,
a.hajda@samsung.com, mchehab@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: [PATCH AUTOSEL 5.10 035/101] media: s5p-mfc: Add checking to s5p_mfc_probe().
Date: Mon, 8 Nov 2021 12:47:25 -0500 [thread overview]
Message-ID: <20211108174832.1189312-35-sashal@kernel.org> (raw)
In-Reply-To: <20211108174832.1189312-1-sashal@kernel.org>
From: Nadezda Lutovinova <lutovinova@ispras.ru>
[ Upstream commit cdfaf4752e6915a4b455ad4400133e540e4dc965 ]
If of_device_get_match_data() return NULL,
then null pointer dereference occurs in s5p_mfc_init_pm().
The patch adds checking if dev->variant is NULL.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
index c763c0a03140c..f336a95432732 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
@@ -1288,6 +1288,10 @@ static int s5p_mfc_probe(struct platform_device *pdev)
}
dev->variant = of_device_get_match_data(&pdev->dev);
+ if (!dev->variant) {
+ dev_err(&pdev->dev, "Failed to get device MFC hardware variant information\n");
+ return -ENOENT;
+ }
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
dev->regs_base = devm_ioremap_resource(&pdev->dev, res);
--
2.33.0
prev parent reply other threads:[~2021-11-09 1:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 17:46 [PATCH AUTOSEL 5.10 001/101] dma-buf: WARN on dmabuf release with pending attachments Sasha Levin
2021-11-08 17:46 ` [PATCH AUTOSEL 5.10 002/101] drm: panel-orientation-quirks: Update the Lenovo Ideapad D330 quirk (v2) Sasha Levin
2021-11-08 17:46 ` [PATCH AUTOSEL 5.10 003/101] drm: panel-orientation-quirks: Add quirk for KD Kurio Smart C15200 2-in-1 Sasha Levin
2021-11-08 17:46 ` [PATCH AUTOSEL 5.10 004/101] drm: panel-orientation-quirks: Add quirk for the Samsung Galaxy Book 10.6 Sasha Levin
2021-11-08 17:46 ` [PATCH AUTOSEL 5.10 005/101] Bluetooth: sco: Fix lock_sock() blockage by memcpy_from_msg() Sasha Levin
2021-11-08 17:46 ` [PATCH AUTOSEL 5.10 006/101] Bluetooth: fix use-after-free error in lock_sock_nested() Sasha Levin
2021-11-08 17:46 ` [PATCH AUTOSEL 5.10 007/101] drm/panel-orientation-quirks: add Valve Steam Deck Sasha Levin
2021-11-08 17:46 ` [PATCH AUTOSEL 5.10 008/101] rcutorture: Avoid problematic critical section nesting on PREEMPT_RT Sasha Levin
2021-11-08 17:46 ` [PATCH AUTOSEL 5.10 009/101] platform/x86: wmi: do not fail if disabling fails Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 010/101] MIPS: lantiq: dma: add small delay after reset Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 011/101] MIPS: lantiq: dma: reset correct number of channel Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 012/101] locking/lockdep: Avoid RCU-induced noinstr fail Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 013/101] net: sched: update default qdisc visibility after Tx queue cnt changes Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 014/101] rcu-tasks: Move RTGS_WAIT_CBS to beginning of rcu_tasks_kthread() loop Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 015/101] smackfs: Fix use-after-free in netlbl_catmap_walk() Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 016/101] ath11k: Align bss_chan_info structure with firmware Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 017/101] NET: IPV4: fix error "do not initialise globals to 0" Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 018/101] x86: Increase exception stack sizes Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 019/101] mwifiex: Run SET_BSS_MODE when changing from P2P to STATION vif-type Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 020/101] mwifiex: Properly initialize private structure on interface type changes Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 021/101] fscrypt: allow 256-bit master keys with AES-256-XTS Sasha Levin
2021-11-09 1:48 ` Eric Biggers
2021-11-14 14:16 ` Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 022/101] drm/amdgpu: Fix MMIO access page fault Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 023/101] ath11k: Avoid reg rules update during firmware recovery Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 024/101] ath11k: add handler for scan event WMI_SCAN_EVENT_DEQUEUED Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 025/101] ath11k: Change DMA_FROM_DEVICE to DMA_TO_DEVICE when map reinjected packets Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 026/101] ath10k: high latency fixes for beacon buffer Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 027/101] media: mt9p031: Fix corrupted frame after restarting stream Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 028/101] media: netup_unidvb: handle interrupt properly according to the firmware Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 029/101] media: atomisp: Fix error handling in probe Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 030/101] media: stm32: Potential NULL pointer dereference in dcmi_irq_thread() Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 031/101] media: uvcvideo: Set capability in s_param Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 032/101] media: uvcvideo: Return -EIO for control errors Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 033/101] media: uvcvideo: Set unique vdev name based in type Sasha Levin
2021-11-08 17:47 ` [PATCH AUTOSEL 5.10 034/101] media: s5p-mfc: fix possible null-pointer dereference in s5p_mfc_probe() Sasha Levin
2021-11-08 17:47 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211108174832.1189312-35-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=a.hajda@samsung.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lutovinova@ispras.ru \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox