From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B99C433F5 for ; Tue, 9 Nov 2021 01:28:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD7BA6134F for ; Tue, 9 Nov 2021 01:28:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243876AbhKIBbU (ORCPT ); Mon, 8 Nov 2021 20:31:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:50184 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244268AbhKIBZF (ORCPT ); Mon, 8 Nov 2021 20:25:05 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 904EA61A55; Tue, 9 Nov 2021 01:09:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636420184; bh=KleTAuiYN08CCakSJryb9oz0+fFiyLC9ruYBaQfpj4A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IPRLd8Mj9wx4T8zag1unBE1M8SbPoFC5J0cNtEZNTb/X0KSnySZFXQ1agHe3ERUrv QcdAgv1dzOEuoaCpH9PmiUPYEn4NP506mql4EH3hVHE3AzQn3GrZRCruP1lhuYLSmx iK0snsy/PSn5ZLMRyXq9NbBlicfxkku575DdSf2HTrJhYGlHHIT+D+i21YQLYdGqPA QxTRTqnKtIiW+ZEUJkhcntfcI7hzPbpCZgGIh8fFgjDGAO+eincn+D/Yvh//2MwGz8 TSOuhUEZk5yfh5llKMmuJPhSqU4FIjHDn35OCnwVi8eaucc37VJvL/89ajJ+BCfnK2 oTzJp5wKC03kg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Randy Dunlap , linux-ia64@vger.kernel.org, Andrew Morton , Tony Luck , Chris Down , Paul Gortmaker , John Paul Adrian Glaubitz , Petr Mladek , Sasha Levin Subject: [PATCH AUTOSEL 4.4 14/30] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK Date: Mon, 8 Nov 2021 20:09:02 -0500 Message-Id: <20211109010918.1192063-14-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211109010918.1192063-1-sashal@kernel.org> References: <20211109010918.1192063-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap [ Upstream commit c15b5fc054c3d6c97e953617605235c5cb8ce979 ] When CONFIG_PRINTK is not set, the CMPXCHG_BUGCHECK() macro calls _printk(), but _printk() is a static inline function, not available as an extern. Since the purpose of the macro is to print the BUGCHECK info, make this config option depend on PRINTK. Fixes multiple occurrences of this build error: ../include/linux/printk.h:208:5: error: static declaration of '_printk' follows non-static declaration 208 | int _printk(const char *s, ...) | ^~~~~~~ In file included from ../arch/ia64/include/asm/cmpxchg.h:5, ../arch/ia64/include/uapi/asm/cmpxchg.h:146:28: note: previous declaration of '_printk' with type 'int(const char *, ...)' 146 | extern int _printk(const char *fmt, ...); Cc: linux-ia64@vger.kernel.org Cc: Andrew Morton Cc: Tony Luck Cc: Chris Down Cc: Paul Gortmaker Cc: John Paul Adrian Glaubitz Signed-off-by: Randy Dunlap Signed-off-by: Petr Mladek Signed-off-by: Sasha Levin --- arch/ia64/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/ia64/Kconfig.debug b/arch/ia64/Kconfig.debug index de9d507ba0fd4..ee6c7f75f479d 100644 --- a/arch/ia64/Kconfig.debug +++ b/arch/ia64/Kconfig.debug @@ -41,7 +41,7 @@ config DISABLE_VHPT config IA64_DEBUG_CMPXCHG bool "Turn on compare-and-exchange bug checking (slow!)" - depends on DEBUG_KERNEL + depends on DEBUG_KERNEL && PRINTK help Selecting this option turns on bug checking for the IA-64 compare-and-exchange instructions. This is slow! Itaniums -- 2.33.0