From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D77C8C433F5 for ; Tue, 9 Nov 2021 01:30:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C32BA610CB for ; Tue, 9 Nov 2021 01:30:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243563AbhKIBc6 (ORCPT ); Mon, 8 Nov 2021 20:32:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:50390 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244298AbhKIBZJ (ORCPT ); Mon, 8 Nov 2021 20:25:09 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7A7F861B48; Tue, 9 Nov 2021 01:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636420190; bh=yt4WxWc8mA1mqGGxncUnXYf9t8HDqrMxQ8cYyQuRUeo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lmIyDlC2UHwnyElWwK7Jtij2w1xXbuCptR7CYS3Xf3NqJ5yN9WOA+AYYhUpv6/Tj9 jt/KQJfYGSRK0RsZZ97KaFDKDy/rvhsc4Sw58zQClm1ewIgLEi9z8h2+7kfAtbCO/w Blvr6R+nlge3szuhI56q+Q+3if/LHOfJClEM/CUeCojZm0VZzG/U3cr6CeLsWYMkhD nikbwPmfseXhUT8jH26mAJU/F5rKvlduhHbLx1zA3SKJ+ZLMHh8kHkZgPMYdruYFVH T+/AvjYTNbP4d73PY7sQiA+bKwTP04rBYeVfFbHcedepR/GFHzVYrHPdyBfxSEqN6A tvWBJpm49HMCQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Steven Rostedt (VMware)" , Sasha Levin , mingo@redhat.com Subject: [PATCH AUTOSEL 4.4 17/30] tracefs: Have tracefs directories not set OTH permission bits by default Date: Mon, 8 Nov 2021 20:09:05 -0500 Message-Id: <20211109010918.1192063-17-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211109010918.1192063-1-sashal@kernel.org> References: <20211109010918.1192063-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Steven Rostedt (VMware)" [ Upstream commit 49d67e445742bbcb03106b735b2ab39f6e5c56bc ] The tracefs file system is by default mounted such that only root user can access it. But there are legitimate reasons to create a group and allow those added to the group to have access to tracing. By changing the permissions of the tracefs mount point to allow access, it will allow group access to the tracefs directory. There should not be any real reason to allow all access to the tracefs directory as it contains sensitive information. Have the default permission of directories being created not have any OTH (other) bits set, such that an admin that wants to give permission to a group has to first disable all OTH bits in the file system. Link: https://lkml.kernel.org/r/20210818153038.664127804@goodmis.org Signed-off-by: Steven Rostedt (VMware) Signed-off-by: Sasha Levin --- fs/tracefs/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c index c66f2423e1f5c..6ccfd47157d37 100644 --- a/fs/tracefs/inode.c +++ b/fs/tracefs/inode.c @@ -429,7 +429,8 @@ static struct dentry *__create_dir(const char *name, struct dentry *parent, if (unlikely(!inode)) return failed_creating(dentry); - inode->i_mode = S_IFDIR | S_IRWXU | S_IRUGO | S_IXUGO; + /* Do not set bits for OTH */ + inode->i_mode = S_IFDIR | S_IRWXU | S_IRUSR| S_IRGRP | S_IXUSR | S_IXGRP; inode->i_op = ops; inode->i_fop = &simple_dir_operations; -- 2.33.0