From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] MIPS: fix duplicated slashes for Platform file path
Date: Tue, 9 Nov 2021 16:32:40 +0100 [thread overview]
Message-ID: <20211109153239.GB13509@alpha.franken.de> (raw)
In-Reply-To: <20211109150146.529428-2-masahiroy@kernel.org>
On Wed, Nov 10, 2021 at 12:01:46AM +0900, Masahiro Yamada wrote:
> platform-y accumulates platform names with a slash appended.
> The current $(patsubst ...) ends up with doubling slashes.
>
> GNU Make still include Platform files, but in case of an error,
> a clumsy file path is displayed:
>
> arch/mips/loongson2ef//Platform:36: *** only binutils >= 2.20.2 have needed option -mfix-loongson2f-nop. Stop.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/mips/Kbuild.platforms | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Kbuild.platforms b/arch/mips/Kbuild.platforms
> index 2c57994b5217..30193bcf9caa 100644
> --- a/arch/mips/Kbuild.platforms
> +++ b/arch/mips/Kbuild.platforms
> @@ -37,4 +37,4 @@ platform-$(CONFIG_MACH_TX49XX) += txx9/
> platform-$(CONFIG_MACH_VR41XX) += vr41xx/
>
> # include the platform specific files
> -include $(patsubst %, $(srctree)/arch/mips/%/Platform, $(platform-y))
> +include $(patsubst %/, $(srctree)/arch/mips/%/Platform, $(platform-y))
> --
> 2.30.2
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2021-11-09 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 15:01 [PATCH 1/2] MIPS: fix *-pkg builds for loongson2ef platform Masahiro Yamada
2021-11-09 15:01 ` [PATCH 2/2] MIPS: fix duplicated slashes for Platform file path Masahiro Yamada
2021-11-09 15:32 ` Thomas Bogendoerfer [this message]
2021-11-09 15:32 ` [PATCH 1/2] MIPS: fix *-pkg builds for loongson2ef platform Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211109153239.GB13509@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox