Re: [v2 10/10] iio: imu: add BNO055 I2C driver

Randy Dunlap
2021-11-09T15:48:12Z

On 11/9/21 3:56 AM, Andrea Merello wrote:
> Il giorno ven 29 ott 2021 alle ore 00:04 Randy Dunlap
> <rdunlap@infradead.org> ha scritto:
>>
>> On 10/28/21 3:18 AM, Andrea Merello wrote:
>>> This path adds an I2C driver for communicating to a BNO055 IMU via I2C bus
>>> and it enables the BNO055 core driver to work in this scenario.
>>>
>>> Signed-off-by: Andrea Merello <andrea.merello@iit.it>
>>> ---
>>> drivers/iio/imu/bno055/Kconfig | 6 ++++
>>> drivers/iio/imu/bno055/Makefile | 1 +
>>> drivers/iio/imu/bno055/bno055_i2c.c | 54 +++++++++++++++++++++++++++++
>>> 3 files changed, 61 insertions(+)
>>> create mode 100644 drivers/iio/imu/bno055/bno055_i2c.c
>>>
>>> diff --git a/drivers/iio/imu/bno055/Kconfig b/drivers/iio/imu/bno055/Kconfig
>>> index 941e43f0368d..87200787d548 100644
>>> --- a/drivers/iio/imu/bno055/Kconfig
>>> +++ b/drivers/iio/imu/bno055/Kconfig
>>> @@ -7,3 +7,9 @@ config BOSH_BNO055_SERIAL
>>> tristate "Bosh BNO055 attached via serial bus"
>>> depends on SERIAL_DEV_BUS
>>> select BOSH_BNO055_IIO
>>> +
>>> +config BOSH_BNO055_I2C
>>> + tristate "Bosh BNO055 attached via I2C bus"
>>> + depends on I2C
>>> + select REGMAP_I2C
>>> + select BOSH_BNO055_IIO
>>
>> Hi,
>>
>> The config entries that have user prompt strings should also
>> have help text. scripts/checkpatch.pl should have told you
>> about that...
>
> I'll add it, thanks. But FYI checkpatch doesn't complain about that here.

Hm, thanks for adding it and telling me about that.

checkpatch.pl does have some code for checking that but I confirmed
that it does not catch this simple case.

Joe, can you identify why checkpatch does not detect missing Kconfig
help text is this simple case?

Thanks.
--
~Randy