Re: [PATCH 20/22] x86,word-at-a-time: Remove .fixup usage

Josh Poimboeuf
2021-11-08T16:47:19Z

On Fri, Nov 05, 2021 at 06:10:43PM +0100, Peter Zijlstra wrote:
> +static inline unsigned long load_unaligned_zeropad(const void *addr)
> +{
> + unsigned long offset, data;
> + unsigned long ret;
> +
> + asm_volatile_goto(
> + "1: mov %[mem], %[ret]\n"
> +
> + _ASM_EXTABLE(1b, %l[do_exception])
> +
> + : [ret] "=&r" (ret)
> + : [mem] "m" (*(unsigned long *)addr)
> + : : do_exception);
> +
> +out:
> + return ret;
> +
> +do_exception: __cold;

Clang doesn't approve of this label annotation:

In file included from fs/dcache.c:186:
./arch/x86/include/asm/word-at-a-time.h:99:15: warning: '__cold__' attribute only applies to functions [-Wignored-attributes]
do_exception: __cold;

--
Josh