From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0C89C433F5 for ; Tue, 9 Nov 2021 22:24:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD7CB61B46 for ; Tue, 9 Nov 2021 22:24:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344623AbhKIW10 (ORCPT ); Tue, 9 Nov 2021 17:27:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:48844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344177AbhKIWZ3 (ORCPT ); Tue, 9 Nov 2021 17:25:29 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0F93361A35; Tue, 9 Nov 2021 22:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636496371; bh=7k1WS9uVJRujblIhvJOmlph87wwIMaxi9obiwhT3fZY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=brQiPAfu7/q5mGLsd7PzgGE+0CEJtMn9Ld15A5G7bwAbvN/H5EL3vD5gnTxADuyY4 nstLWCKVtmlfUiYYMJpfUyvYzZ0vRfei+KHqGgMnQX41mBmUBo0W3Ut/om043K3w0a gty/H9y7mwaHwOCz+JiigcO48kvEf5Yzrxcmq01s/hlJE7ohK+/UtwxpCMpSqseUiw EJZ0f9rjRQoxOzvFEg5QYD24fX4gX5y8aFhDZMS9rPYKDqP01z7XfW+NGk7+w4QU1e nC2fvJbdNN4rZPMx7j3q3fKi7T42CN5N+3ci814o+1VKIkpR6WbmFu3rWzL1w/ut7O Jzm9wed1qxgrQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ajish Koshy , Jack Wang , Viswas G , "Martin K . Petersen" , Sasha Levin , jinpu.wang@profitbricks.com, lindar_liu@usish.com, JBottomley@odin.com, pmchba@pmcs.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.14 12/75] scsi: pm80xx: Fix memory leak during rmmod Date: Tue, 9 Nov 2021 17:18:02 -0500 Message-Id: <20211109221905.1234094-12-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211109221905.1234094-1-sashal@kernel.org> References: <20211109221905.1234094-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ajish Koshy [ Upstream commit 51e6ed83bb4ade7c360551fa4ae55c4eacea354b ] Driver failed to release all memory allocated. This would lead to memory leak during driver removal. Properly free memory when the module is removed. Link: https://lore.kernel.org/r/20210906170404.5682-5-Ajish.Koshy@microchip.com Acked-by: Jack Wang Signed-off-by: Ajish Koshy Signed-off-by: Viswas G Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/pm8001/pm8001_init.c | 11 +++++++++++ drivers/scsi/pm8001/pm8001_sas.h | 1 + 2 files changed, 12 insertions(+) diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c index 47db7e0beae6f..729d8252028e8 100644 --- a/drivers/scsi/pm8001/pm8001_init.c +++ b/drivers/scsi/pm8001/pm8001_init.c @@ -1198,6 +1198,7 @@ pm8001_init_ccb_tag(struct pm8001_hba_info *pm8001_ha, struct Scsi_Host *shost, goto err_out; /* Memory region for ccb_info*/ + pm8001_ha->ccb_count = ccb_count; pm8001_ha->ccb_info = kcalloc(ccb_count, sizeof(struct pm8001_ccb_info), GFP_KERNEL); if (!pm8001_ha->ccb_info) { @@ -1259,6 +1260,16 @@ static void pm8001_pci_remove(struct pci_dev *pdev) tasklet_kill(&pm8001_ha->tasklet[j]); #endif scsi_host_put(pm8001_ha->shost); + + for (i = 0; i < pm8001_ha->ccb_count; i++) { + dma_free_coherent(&pm8001_ha->pdev->dev, + sizeof(struct pm8001_prd) * PM8001_MAX_DMA_SG, + pm8001_ha->ccb_info[i].buf_prd, + pm8001_ha->ccb_info[i].ccb_dma_handle); + } + kfree(pm8001_ha->ccb_info); + kfree(pm8001_ha->devices); + pm8001_free(pm8001_ha); kfree(sha->sas_phy); kfree(sha->sas_port); diff --git a/drivers/scsi/pm8001/pm8001_sas.h b/drivers/scsi/pm8001/pm8001_sas.h index 62d08b535a4b6..f5b6a9d8099e5 100644 --- a/drivers/scsi/pm8001/pm8001_sas.h +++ b/drivers/scsi/pm8001/pm8001_sas.h @@ -516,6 +516,7 @@ struct pm8001_hba_info { u32 iomb_size; /* SPC and SPCV IOMB size */ struct pm8001_device *devices; struct pm8001_ccb_info *ccb_info; + u32 ccb_count; #ifdef PM8001_USE_MSIX int number_of_intr;/*will be used in remove()*/ char intr_drvname[PM8001_MAX_MSIX_VEC] -- 2.33.0