From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40CF3C4332F for ; Tue, 9 Nov 2021 22:30:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26DA561208 for ; Tue, 9 Nov 2021 22:30:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344781AbhKIWcx (ORCPT ); Tue, 9 Nov 2021 17:32:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:55040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344783AbhKIWar (ORCPT ); Tue, 9 Nov 2021 17:30:47 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9150261A83; Tue, 9 Nov 2021 22:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636496456; bh=FBGqdI/gpRB/up5rvyajZVtnMsCexH6EFgCaJlPrnSo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f+bdpwojp2yVQD7siA7AI0O+IDVg+JIgPD/nIv3CTguTHoCcg1CdekHc+cnlXsB2i JK5B9WQkO700nZuI99bb1R2oBRXM8H0zP5n78GFzLo4Q3O6idRGfngNtOOIxhfyUme sjkqGbKRwSrlamBKrUixCh7+/bxd1FFTFqylfukvexGtOk+mZgZ1B7A77erJ4UmMUm s1XScrn2AZ6FB4oYGjy2HoU0hYxk/KTlbrbudHl0wdFstzNa2DSBICvx6Z57ztClzp 7msuFXN+035PFKpU1TpsMTce9NkeI4dE24hcWmcKhaAOKeYC35cjk9vSnqkMTPF0ia O88569gmiv9cw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chengfeng Ye , Takashi Iwai , Sasha Levin , perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.14 71/75] ALSA: usb-audio: fix null pointer dereference on pointer cs_desc Date: Tue, 9 Nov 2021 17:19:01 -0500 Message-Id: <20211109221905.1234094-71-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211109221905.1234094-1-sashal@kernel.org> References: <20211109221905.1234094-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chengfeng Ye [ Upstream commit b97053df0f04747c3c1e021ecbe99db675342954 ] The pointer cs_desc return from snd_usb_find_clock_source could be null, so there is a potential null pointer dereference issue. Fix this by adding a null check before dereference. Signed-off-by: Chengfeng Ye Link: https://lore.kernel.org/r/20211024111736.11342-1-cyeaa@connect.ust.hk Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/usb/clock.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/usb/clock.c b/sound/usb/clock.c index 14456f61539e1..6c3f3312113f6 100644 --- a/sound/usb/clock.c +++ b/sound/usb/clock.c @@ -499,6 +499,10 @@ int snd_usb_set_sample_rate_v2v3(struct snd_usb_audio *chip, union uac23_clock_source_desc *cs_desc; cs_desc = snd_usb_find_clock_source(chip, clock, fmt->protocol); + + if (!cs_desc) + return 0; + if (fmt->protocol == UAC_VERSION_3) bmControls = le32_to_cpu(cs_desc->v3.bmControls); else -- 2.33.0