* [PATCH v1 1/1] kunit: Replace kernel.h with the necessary inclusions
@ 2021-11-10 10:35 Andy Shevchenko
2021-11-15 11:34 ` Andy Shevchenko
2021-12-09 12:26 ` Andy Shevchenko
0 siblings, 2 replies; 4+ messages in thread
From: Andy Shevchenko @ 2021-11-10 10:35 UTC (permalink / raw)
To: Andy Shevchenko, linux-kselftest, kunit-dev, linux-kernel; +Cc: Brendan Higgins
When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.
Replace kernel.h inclusion with the list of what is really being used.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/kunit/assert.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/kunit/assert.h b/include/kunit/assert.h
index ad889b539ab3..ccbc36c0b02f 100644
--- a/include/kunit/assert.h
+++ b/include/kunit/assert.h
@@ -10,7 +10,7 @@
#define _KUNIT_ASSERT_H
#include <linux/err.h>
-#include <linux/kernel.h>
+#include <linux/printk.h>
struct kunit;
struct string_stream;
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] kunit: Replace kernel.h with the necessary inclusions
2021-11-10 10:35 [PATCH v1 1/1] kunit: Replace kernel.h with the necessary inclusions Andy Shevchenko
@ 2021-11-15 11:34 ` Andy Shevchenko
2021-11-23 16:30 ` Andy Shevchenko
2021-12-09 12:26 ` Andy Shevchenko
1 sibling, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2021-11-15 11:34 UTC (permalink / raw)
To: linux-kselftest, kunit-dev, linux-kernel; +Cc: Brendan Higgins
On Wed, Nov 10, 2021 at 12:35:52PM +0200, Andy Shevchenko wrote:
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
>
> Replace kernel.h inclusion with the list of what is really being used.
Can it be applied now?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] kunit: Replace kernel.h with the necessary inclusions
2021-11-15 11:34 ` Andy Shevchenko
@ 2021-11-23 16:30 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2021-11-23 16:30 UTC (permalink / raw)
To: linux-kselftest, kunit-dev, linux-kernel; +Cc: Brendan Higgins
On Mon, Nov 15, 2021 at 01:34:08PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 10, 2021 at 12:35:52PM +0200, Andy Shevchenko wrote:
> > When kernel.h is used in the headers it adds a lot into dependency hell,
> > especially when there are circular dependencies are involved.
> >
> > Replace kernel.h inclusion with the list of what is really being used.
>
> Can it be applied now?
Any news so far? Should I do anything about this patch?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] kunit: Replace kernel.h with the necessary inclusions
2021-11-10 10:35 [PATCH v1 1/1] kunit: Replace kernel.h with the necessary inclusions Andy Shevchenko
2021-11-15 11:34 ` Andy Shevchenko
@ 2021-12-09 12:26 ` Andy Shevchenko
1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2021-12-09 12:26 UTC (permalink / raw)
To: linux-kselftest, kunit-dev, linux-kernel; +Cc: Brendan Higgins
On Wed, Nov 10, 2021 at 12:35:52PM +0200, Andy Shevchenko wrote:
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
>
> Replace kernel.h inclusion with the list of what is really being used.
Folks, this patch is dated month ago and nothing in return.
Does the Kunit subsystem abandoned / orphaned? Should I send and update
to MAINTAINERS? Should I escalate this?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-09 12:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-10 10:35 [PATCH v1 1/1] kunit: Replace kernel.h with the necessary inclusions Andy Shevchenko
2021-11-15 11:34 ` Andy Shevchenko
2021-11-23 16:30 ` Andy Shevchenko
2021-12-09 12:26 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox