Re: [PATCH v2 1/4] Input: Add driver for Cypress Generation 5 touchscreen

Andreas Kemnade
2021-12-13T18:49:19Z

Hi,

On Sun, 12 Dec 2021 21:45:48 -0800
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:

> > > > + rc = devm_request_threaded_irq(dev, irq, NULL, cyttsp5_handle_irq,
> > > > + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> > >
> > > Please do not override platform setup with hardcoded triggers. Also, it
> > > is strongly recommended to use level interrupts for these peripherals.
> > >
> > > This is also likely unsafe if controller is not completely shut off and
> > > is capable of generating interrupts given input device is not yet
> > > allocated.
> >
> > I have dropped the `IRQF_TRIGGER_FALLING |`
> >
> > I have tried to use level interrupts, but I can't get the device
> > working with them.
>
> That is weird, does the interrupt controller support level interrupts?
>
hmm, it should, at least on the imx6 I am using them for some other
devices, I guess, on the imx7 they should work, too.
I hope I find time to give that a try the next days.

Regards,
Andreas