From: kernel test robot <lkp@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: drivers/net/ethernet/sis/sis900.c:393 sis96x_get_mac_addr() warn: inconsistent indenting
Date: Fri, 12 Nov 2021 04:47:23 +0800 [thread overview]
Message-ID: <202111120419.fluV3QSv-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2314 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: debe436e77c72fcee804fb867f275e6d31aa999c
commit: 923ca6f61887c9ed5797af096ffb23bdb6e4c6fa ethernet: replace netdev->dev_addr 16bit writes
date: 4 weeks ago
config: i386-randconfig-m021-20211019 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
smatch warnings:
drivers/net/ethernet/sis/sis900.c:393 sis96x_get_mac_addr() warn: inconsistent indenting
vim +393 drivers/net/ethernet/sis/sis900.c
360
361 /**
362 * sis96x_get_mac_addr - Get MAC address for SiS962 or SiS963 model
363 * @pci_dev: the sis900 pci device
364 * @net_dev: the net device to get address for
365 *
366 * SiS962 or SiS963 model, use EEPROM to store MAC address. And EEPROM
367 * is shared by
368 * LAN and 1394. When accessing EEPROM, send EEREQ signal to hardware first
369 * and wait for EEGNT. If EEGNT is ON, EEPROM is permitted to be accessed
370 * by LAN, otherwise it is not. After MAC address is read from EEPROM, send
371 * EEDONE signal to refuse EEPROM access by LAN.
372 * The EEPROM map of SiS962 or SiS963 is different to SiS900.
373 * The signature field in SiS962 or SiS963 spec is meaningless.
374 * MAC address is read into @net_dev->dev_addr.
375 */
376
377 static int sis96x_get_mac_addr(struct pci_dev *pci_dev,
378 struct net_device *net_dev)
379 {
380 struct sis900_private *sis_priv = netdev_priv(net_dev);
381 void __iomem *ioaddr = sis_priv->ioaddr;
382 u16 addr[ETH_ALEN / 2];
383 int wait, rc = 0;
384
385 sw32(mear, EEREQ);
386 for (wait = 0; wait < 2000; wait++) {
387 if (sr32(mear) & EEGNT) {
388 int i;
389
390 /* get MAC address from EEPROM */
391 for (i = 0; i < 3; i++)
392 addr[i] = read_eeprom(ioaddr, i + EEPROMMACAddr);
> 393 eth_hw_addr_set(net_dev, (u8 *)addr);
394
395 rc = 1;
396 break;
397 }
398 udelay(1);
399 }
400 sw32(mear, EEDONE);
401 return rc;
402 }
403
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41486 bytes --]
reply other threads:[~2021-11-11 20:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111120419.fluV3QSv-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox