Re: [PATCH v2 1/2] dt-bindings: usb: Add Apple dwc3 bindings

Sven Peter
2021-11-29T22:35:26Z

Hi,

Thanks for the review!

On Mon, Nov 29, 2021, at 02:27, Rob Herring wrote:
> On Mon, Nov 08, 2021 at 06:09:45PM +0100, Sven Peter wrote:
>> Apple Silicon SoCs such as the M1 have multiple USB controllers based on
>> the Synopsys DesignWare USB3 controller.
>> References to the ATC PHY required for SuperSpeed are left out for now
>> until support has been upstreamed as well.
>>
>> Signed-off-by: Sven Peter <sven@svenpeter.dev>
>> ---
>> v1 -> v2:
>> - added apple,dwc3 bindings instead of a property for the reset quirk
>> as requested by robh
>>
>> I think I have to use GPL-2.0 for this binding since it's based
>> on and references snps,dwc3.yaml which is also only GPL-2.0.
>> Otherwise I'd be fine with the usual GPL/BSD dual license as well.
>>
>> .../devicetree/bindings/usb/apple,dwc3.yaml | 64 +++++++++++++++++++
>> MAINTAINERS | 1 +
>> 2 files changed, 65 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/usb/apple,dwc3.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/usb/apple,dwc3.yaml b/Documentation/devicetree/bindings/usb/apple,dwc3.yaml
>> new file mode 100644
>> index 000000000000..fb3b3489e6b2
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/usb/apple,dwc3.yaml
>> @@ -0,0 +1,64 @@
>> +# SPDX-License-Identifier: GPL-2.0
>
> Dual license please.

I'd like to but I'm not sure if I can do that. This binding is based on
snps,dwc3.yaml and rockchip,dwc3.yaml which are both only GPL-2.0.

>
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/usb/apple,dwc3.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Apple Silicon DWC3 USB controller
>> +
>> +maintainers:
>> + - Sven Peter <sven@svenpeter.dev>
>> +
>> +description:
>> + On Apple Silicon SoCs such as the M1 each Type-C port has a corresponding
>> + USB controller based on the Synopsys DesignWare USB3 controller.
>> +
>> + The common content of this binding is defined in snps,dwc3.yaml.
>> +
>> +allOf:
>> + - $ref: snps,dwc3.yaml#
>> +
>> +select:
>> + properties:
>> + compatible:
>> + contains:
>> + const: apple,dwc3
>
> This needs to list all possible compatibles except snps,dwc3 so the
> schema is applied for any incorrect mixture of compatibles.

Makes sense, will do that for the next version.

Thanks,

Sven