Re: [PATCH v2 1/6] net: ocelot: add support to get port mac from device-tree

Vladimir Oltean
2021-11-03T10:26:32Z

On Wed, Nov 03, 2021 at 10:19:38AM +0100, Clément Léger wrote:
> Add support to get mac from device-tree using of_get_mac_address.
>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

> drivers/net/ethernet/mscc/ocelot_net.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mscc/ocelot_net.c b/drivers/net/ethernet/mscc/ocelot_net.c
> index eaeba60b1bba..d76def435b23 100644
> --- a/drivers/net/ethernet/mscc/ocelot_net.c
> +++ b/drivers/net/ethernet/mscc/ocelot_net.c
> @@ -1704,7 +1704,10 @@ int ocelot_probe_port(struct ocelot *ocelot, int port, struct regmap *target,
> NETIF_F_HW_TC;
> dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER | NETIF_F_HW_TC;
>
> - eth_hw_addr_gen(dev, ocelot->base_mac, port);
> + err = of_get_mac_address(portnp, dev->dev_addr);
> + if (err)
> + eth_hw_addr_gen(dev, ocelot->base_mac, port);
> +
> ocelot_mact_learn(ocelot, PGID_CPU, dev->dev_addr,
> OCELOT_VLAN_UNAWARE_PVID, ENTRYTYPE_LOCKED);
>
> --
> 2.33.0
>