From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59368C433F5 for ; Tue, 16 Nov 2021 01:22:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B6DC61BF8 for ; Tue, 16 Nov 2021 01:22:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378305AbhKPBWF (ORCPT ); Mon, 15 Nov 2021 20:22:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:42932 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244219AbhKOTMK (ORCPT ); Mon, 15 Nov 2021 14:12:10 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3D0D0634A5; Mon, 15 Nov 2021 18:19:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637000360; bh=RipKnghJetfR6VOGmIU6oRF+ArQW+BVj6gzzGdCdxdQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0hc9LxYlZQfvUqmNzQ0BPR1fDD+LqgybWx2bvxUa46xl/K4XULI7jO7Z0clqrRDV0 xWI0yOB8YNLm99yxMCAAq7fAWoSl/mmfwHaglZoc5agW6kHSrDzSk8RNUO8a7dXDFa XYaNFyasmgUgjTV+WYHLy6nr9sRmCd843b7GIJ3g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Guru Das Srinagesh , Stephen Boyd , Bjorn Andersson , Sasha Levin Subject: [PATCH 5.14 631/849] firmware: qcom_scm: Fix error retval in __qcom_scm_is_call_available() Date: Mon, 15 Nov 2021 18:01:54 +0100 Message-Id: <20211115165441.617092217@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211115165419.961798833@linuxfoundation.org> References: <20211115165419.961798833@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guru Das Srinagesh [ Upstream commit 38212b2a8a6fc4c3a6fa99d7445b833bedc9a67c ] Since __qcom_scm_is_call_available() returns bool, have it return false instead of -EINVAL if an invalid SMC convention is detected. This fixes the Smatch static checker warning: drivers/firmware/qcom_scm.c:255 __qcom_scm_is_call_available() warn: signedness bug returning '(-22)' Fixes: 9d11af8b06a8 ("firmware: qcom_scm: Make __qcom_scm_is_call_available() return bool") Reported-by: Dan Carpenter Signed-off-by: Guru Das Srinagesh Reviewed-by: Stephen Boyd Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/1633982414-28347-1-git-send-email-quic_gurus@quicinc.com Signed-off-by: Sasha Levin --- drivers/firmware/qcom_scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index 47ea2bd42b100..0aa0fe86ca8c7 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -252,7 +252,7 @@ static bool __qcom_scm_is_call_available(struct device *dev, u32 svc_id, break; default: pr_err("Unknown SMC convention being used\n"); - return -EINVAL; + return false; } ret = qcom_scm_call(dev, &desc, &res); -- 2.33.0