From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AB21C4321E for ; Tue, 16 Nov 2021 00:36:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E108D619E1 for ; Tue, 16 Nov 2021 00:36:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346018AbhKPAjb (ORCPT ); Mon, 15 Nov 2021 19:39:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:45392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344836AbhKOTZf (ORCPT ); Mon, 15 Nov 2021 14:25:35 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id BCFE763236; Mon, 15 Nov 2021 19:05:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637003118; bh=fks25m95ylT9sOoOxCGCDkMxg9akX8lyYSWHnRHlSo4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cF155DSNkxP7Q4FK9YhsyRHoL6HEBxz/bACCKDvreGHxSXpbr+O9NIl3D1X/hNBZl XIZvGZV7NyLLU6ejJRplxFr9m06ICZY/ZyBJcCRb47xTnsRBmtbHmotwD8bzKXU7Z7 Fpfrl5CJAgjNxr9mvT0Y9CXF1ejfBW03uLGTQdHw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , "David S. Miller" , Sasha Levin Subject: [PATCH 5.15 818/917] litex_liteeth: Fix a double free in the remove function Date: Mon, 15 Nov 2021 18:05:13 +0100 Message-Id: <20211115165456.777049477@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211115165428.722074685@linuxfoundation.org> References: <20211115165428.722074685@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit c45231a7668d6b632534f692b10592ea375b55b0 ] 'netdev' is a managed resource allocated in the probe using 'devm_alloc_etherdev()'. It must not be freed explicitly in the remove function. Fixes: ee7da21ac4c3 ("net: Add driver for LiteX's LiteETH network interface") Signed-off-by: Christophe JAILLET Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/litex/litex_liteeth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c index a9bdbf0dcfe1e..5bb1cc8a2ce13 100644 --- a/drivers/net/ethernet/litex/litex_liteeth.c +++ b/drivers/net/ethernet/litex/litex_liteeth.c @@ -289,7 +289,6 @@ static int liteeth_remove(struct platform_device *pdev) struct net_device *netdev = platform_get_drvdata(pdev); unregister_netdev(netdev); - free_netdev(netdev); return 0; } -- 2.33.0