From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: <linux-kernel@vger.kernel.org>,
Russell King <rmk+kernel@armlinux.org.uk>,
<linux-mips@vger.kernel.org>, John Crispin <john@phrozen.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
Jonathan Cameron <jic23@kernel.org>, <linux-iio@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH] mips: lantiq: add support for clk_get_parent()
Date: Mon, 15 Nov 2021 17:51:52 +0000 [thread overview]
Message-ID: <20211115175152.000030d6@Huawei.com> (raw)
In-Reply-To: <20211115012051.16302-1-rdunlap@infradead.org>
On Sun, 14 Nov 2021 17:20:51 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:
> Provide a simple implementation of clk_get_parent() in the
> lantiq subarch so that callers of it will build without errors.
>
> Fixes this build error:
> ERROR: modpost: "clk_get_parent" [drivers/iio/adc/ingenic-adc.ko] undefined!
>
> Fixes: 171bb2f19ed6 ("MIPS: Lantiq: Add initial support for Lantiq SoCs")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> Cc: linux-mips@vger.kernel.org
> Cc: John Crispin <john@phrozen.org>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: linux-iio@vger.kernel.org
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Thanks for tidying this up.
Jonathan
> ---
> arch/mips/lantiq/clk.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> --- linux-next-20211112.orig/arch/mips/lantiq/clk.c
> +++ linux-next-20211112/arch/mips/lantiq/clk.c
> @@ -158,6 +158,12 @@ void clk_deactivate(struct clk *clk)
> }
> EXPORT_SYMBOL(clk_deactivate);
>
> +struct clk *clk_get_parent(struct clk *clk)
> +{
> + return NULL;
> +}
> +EXPORT_SYMBOL(clk_get_parent);
> +
> static inline u32 get_counter_resolution(void)
> {
> u32 res;
next prev parent reply other threads:[~2021-11-15 19:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 1:20 [PATCH] mips: lantiq: add support for clk_get_parent() Randy Dunlap
2021-11-15 17:51 ` Jonathan Cameron [this message]
2021-11-15 17:58 ` John Crispin
2021-11-16 8:46 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115175152.000030d6@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=john@phrozen.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rdunlap@infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).