* [paulmck-rcu:dev.2021.11.10a 81/96] kernel/rcu/tasks.h:181:25: sparse: sparse: incorrect type in argument 1 (different modifiers)
@ 2021-11-18 1:41 kernel test robot
2021-11-18 3:01 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-11-18 1:41 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: kbuild-all, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2773 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2021.11.10a
head: cfbd3769397911e7f1561fa57b4490b1e4fed9de
commit: a3ecbdd6d841a025ebe87b79c7538b4dc44edc94 [81/96] rcu-tasks: Use spin_lock_rcu_node() and friends
config: arm-randconfig-s032-20211115 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?id=a3ecbdd6d841a025ebe87b79c7538b4dc44edc94
git remote add paulmck-rcu https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
git fetch --no-tags paulmck-rcu dev.2021.11.10a
git checkout a3ecbdd6d841a025ebe87b79c7538b4dc44edc94
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
kernel/rcu/update.c: note: in included file:
>> kernel/rcu/tasks.h:181:25: sparse: sparse: incorrect type in argument 1 (different modifiers) @@ expected struct raw_spinlock [usertype] *lock @@ got struct raw_spinlock [noderef] * @@
kernel/rcu/tasks.h:181:25: sparse: expected struct raw_spinlock [usertype] *lock
kernel/rcu/tasks.h:181:25: sparse: got struct raw_spinlock [noderef] *
vim +181 kernel/rcu/tasks.h
165
166 // Initialize per-CPU callback lists for the specified flavor of
167 // Tasks RCU.
168 static void cblist_init_generic(struct rcu_tasks *rtp)
169 {
170 int cpu;
171 unsigned long flags;
172
173 raw_spin_lock_irqsave(&rtp->cbs_gbl_lock, flags);
174 rtp->percpu_enqueue_shift = ilog2(nr_cpu_ids);
175 for_each_possible_cpu(cpu) {
176 struct rcu_tasks_percpu *rtpcp = per_cpu_ptr(rtp->rtpcpu, cpu);
177
178 pr_info("%s initializing CPU %d rcu_tasks_percpu structure for %s\n", __func__, cpu, rtp->name);
179 WARN_ON_ONCE(!rtpcp);
180 if (cpu)
> 181 raw_spin_lock_init(&rtpcp->lock);
182 raw_spin_lock_irqsave_rcu_node(rtpcp, flags);
183 if (rcu_segcblist_empty(&rtpcp->cblist))
184 rcu_segcblist_init(&rtpcp->cblist);
185 raw_spin_unlock_irqrestore_rcu_node(rtpcp, flags);
186 }
187 raw_spin_unlock_irqrestore(&rtp->cbs_gbl_lock, flags);
188
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35762 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [paulmck-rcu:dev.2021.11.10a 81/96] kernel/rcu/tasks.h:181:25: sparse: sparse: incorrect type in argument 1 (different modifiers)
2021-11-18 1:41 [paulmck-rcu:dev.2021.11.10a 81/96] kernel/rcu/tasks.h:181:25: sparse: sparse: incorrect type in argument 1 (different modifiers) kernel test robot
@ 2021-11-18 3:01 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2021-11-18 3:01 UTC (permalink / raw)
To: kernel test robot; +Cc: kbuild-all, linux-kernel
On Thu, Nov 18, 2021 at 09:41:40AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2021.11.10a
> head: cfbd3769397911e7f1561fa57b4490b1e4fed9de
> commit: a3ecbdd6d841a025ebe87b79c7538b4dc44edc94 [81/96] rcu-tasks: Use spin_lock_rcu_node() and friends
> config: arm-randconfig-s032-20211115 (attached as .config)
> compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # apt-get install sparse
> # sparse version: v0.6.4-dirty
> # https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?id=a3ecbdd6d841a025ebe87b79c7538b4dc44edc94
> git remote add paulmck-rcu https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
> git fetch --no-tags paulmck-rcu dev.2021.11.10a
> git checkout a3ecbdd6d841a025ebe87b79c7538b4dc44edc94
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
Good catch, a missing ACCESS_PRIVATE. Will fix, thank you!
Thanx, Paul
> sparse warnings: (new ones prefixed by >>)
> kernel/rcu/update.c: note: in included file:
> >> kernel/rcu/tasks.h:181:25: sparse: sparse: incorrect type in argument 1 (different modifiers) @@ expected struct raw_spinlock [usertype] *lock @@ got struct raw_spinlock [noderef] * @@
> kernel/rcu/tasks.h:181:25: sparse: expected struct raw_spinlock [usertype] *lock
> kernel/rcu/tasks.h:181:25: sparse: got struct raw_spinlock [noderef] *
>
> vim +181 kernel/rcu/tasks.h
>
> 165
> 166 // Initialize per-CPU callback lists for the specified flavor of
> 167 // Tasks RCU.
> 168 static void cblist_init_generic(struct rcu_tasks *rtp)
> 169 {
> 170 int cpu;
> 171 unsigned long flags;
> 172
> 173 raw_spin_lock_irqsave(&rtp->cbs_gbl_lock, flags);
> 174 rtp->percpu_enqueue_shift = ilog2(nr_cpu_ids);
> 175 for_each_possible_cpu(cpu) {
> 176 struct rcu_tasks_percpu *rtpcp = per_cpu_ptr(rtp->rtpcpu, cpu);
> 177
> 178 pr_info("%s initializing CPU %d rcu_tasks_percpu structure for %s\n", __func__, cpu, rtp->name);
> 179 WARN_ON_ONCE(!rtpcp);
> 180 if (cpu)
> > 181 raw_spin_lock_init(&rtpcp->lock);
> 182 raw_spin_lock_irqsave_rcu_node(rtpcp, flags);
> 183 if (rcu_segcblist_empty(&rtpcp->cblist))
> 184 rcu_segcblist_init(&rtpcp->cblist);
> 185 raw_spin_unlock_irqrestore_rcu_node(rtpcp, flags);
> 186 }
> 187 raw_spin_unlock_irqrestore(&rtp->cbs_gbl_lock, flags);
> 188
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-18 3:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-18 1:41 [paulmck-rcu:dev.2021.11.10a 81/96] kernel/rcu/tasks.h:181:25: sparse: sparse: incorrect type in argument 1 (different modifiers) kernel test robot
2021-11-18 3:01 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox