From: Masami Hiramatsu <mhiramat@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, aou@eecs.berkeley.edu,
borntraeger@de.ibm.com, bp@alien8.de, broonie@kernel.org,
catalin.marinas@arm.com, dave.hansen@linux.intel.com,
gor@linux.ibm.com, hca@linux.ibm.com,
linux-kernel@vger.kernel.org, madvenka@linux.microsoft.com,
mhiramat@kernel.org, mingo@redhat.com, mpe@ellerman.id.au,
palmer@dabbelt.com, paul.walmsley@sifive.com,
peterz@infradead.org, rostedt@goodmis.org, tglx@linutronix.de,
will@kernel.org
Subject: Re: [PATCH 2/9] arm64: Add comment for stack_info::kr_cur
Date: Fri, 19 Nov 2021 07:25:03 +0900 [thread overview]
Message-ID: <20211119072503.9834585ea5c812a63195816a@kernel.org> (raw)
In-Reply-To: <20211117140737.44420-3-mark.rutland@arm.com>
On Wed, 17 Nov 2021 14:07:30 +0000
Mark Rutland <mark.rutland@arm.com> wrote:
> We added stack_info::kr_cur in commit:
>
> cd9bc2c9258816dc ("arm64: Recover kretprobe modified return address in stacktrace")
>
> ... but didn't add anything in the corresponding comment block.
Thanks for adding the comment!
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Regards,
>
> For consistency, add a corresponding comment.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Masami Hiramatsu <mhiramat@kernel.org>
> Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Cc: Will Deacon <will@kernel.org>
> ---
> arch/arm64/include/asm/stacktrace.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/include/asm/stacktrace.h b/arch/arm64/include/asm/stacktrace.h
> index 6564a01cc085..686731b9df05 100644
> --- a/arch/arm64/include/asm/stacktrace.h
> +++ b/arch/arm64/include/asm/stacktrace.h
> @@ -47,6 +47,10 @@ struct stack_info {
> * @prev_type: The type of stack this frame record was on, or a synthetic
> * value of STACK_TYPE_UNKNOWN. This is used to detect a
> * transition from one stack to another.
> + *
> + * @kr_cur: When KRETPOLINES is selected, holds the kretprobe instance
> + * associated with the most recently encountered replacement lr
> + * value.
> */
> struct stackframe {
> unsigned long fp;
> --
> 2.11.0
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-11-18 22:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 14:07 [PATCH 0/9] arm64: stacktrace: unify unwind code Mark Rutland
2021-11-17 14:07 ` [PATCH 1/9] arch: Make ARCH_STACKWALK independent of STACKTRACE Mark Rutland
2021-11-17 14:07 ` [PATCH 2/9] arm64: Add comment for stack_info::kr_cur Mark Rutland
2021-11-17 15:23 ` Mark Brown
2021-11-18 22:25 ` Masami Hiramatsu [this message]
2021-11-23 11:47 ` Mark Rutland
2021-11-17 14:07 ` [PATCH 3/9] arm64: Mark __switch_to() as __sched Mark Rutland
2021-11-17 15:42 ` Mark Brown
2021-11-17 14:07 ` [PATCH 4/9] arm64: Make perf_callchain_kernel() use arch_stack_walk() Mark Rutland
2021-11-17 14:07 ` [PATCH 5/9] arm64: Make __get_wchan() " Mark Rutland
2021-11-17 15:50 ` Mark Brown
2021-11-17 14:07 ` [PATCH 6/9] arm64: Make return_address() " Mark Rutland
2021-11-17 14:07 ` [PATCH 7/9] arm64: Make profile_pc() " Mark Rutland
2021-11-17 15:31 ` Mark Brown
2021-11-17 14:07 ` [PATCH 8/9] arm64: Make dump_backtrace() " Mark Rutland
2021-11-17 15:36 ` Mark Brown
2021-11-17 14:07 ` [PATCH 9/9] arm64: Make some stacktrace functions private Mark Rutland
2021-11-17 15:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211119072503.9834585ea5c812a63195816a@kernel.org \
--to=mhiramat@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madvenka@linux.microsoft.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox